Skip to content

fix: confirmation window is displayed after save for dropdown #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmltaWt0 wants to merge 4 commits into from
Closed

fix: confirmation window is displayed after save for dropdown #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddbc13b
fix: confirmation window is displayed after save for dropdown
cmltaWt0 Sep 13, 2024
ae95ce5
fix: use safe string coercion for answer titles in checkForNoAnswers
filippovskii09 Dec 13, 2025
3e7ac94
fix: resolve test error
filippovskii09 Dec 13, 2025
fb5b1e0
Merge remote-tracking branch 'origin/master' into fix-confirmation-wi…
filippovskii09 Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/editors/containers/ProblemEditor/components/EditProblemView/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ export const checkForNoAnswers = ({ openSaveWarningModal, problem }) => {
const hasTitle = () => {
const titles = [];
answers.forEach(answer => {
const title = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id];
const rawVal = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id];
const title = String(rawVal ?? '');
if (title?.length > 0) {
titles.push(title);
}
Expand All @@ -125,8 +126,9 @@ export const checkForNoAnswers = ({ openSaveWarningModal, problem }) => {
let correctAnswer;
answers.forEach(answer => {
if (answer.correct) {
const title = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id];
if (title?.length > 0) {
const rawVal = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id];
const title = String(rawVal ?? '');
if (title.length > 0) {
Copy link
Copy Markdown
Contributor

@bradenmacdonald bradenmacdonald Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we certain that title is always going to be defined? There's no type information here so I don't really know, but it seems safer to leave it as title?.length just in case.

correctAnswer = true;
}
}
Expand Down
16 changes: 16 additions & 0 deletions src/editors/containers/ProblemEditor/components/EditProblemView/hooks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,22 @@ describe('EditProblemView hooks parseState', () => {
expect(openSaveWarningModal).toHaveBeenCalled();
expect(content).toEqual(null);
});
it('should return the correct content if the user entered a number as the correct answer for a dropdown type problem', () => {
const problem = { ...problemState, answers: [{ id: 'A', title: 1234, correct: true }] };
const content = hooks.getContent({
isAdvancedProblemType: false,
problemState: problem,
editorRef,
assets,
lmsEndpointUrl,
openSaveWarningModal,
});
expect(openSaveWarningModal).toHaveBeenCalled();
expect(content).toEqual({
olx: mockBuiltOLX,
settings: expectedSettings,
});
});
});
});

Expand Down
Loading