feat: add asset existence check before replacing static URLs

[bra-i-am]

Description

This merge request solves an issue where the save warning is shown without making changes to new courses. Additionally, it also adds an existence check before replacing the static URLs

Supporting information

#1265

Testing instructions

1. Mount this MFE in a Tutor environment and git switch to this branch
2. Enable contentstore.new_studio_mfe.use_new_schedule_details_page
3. Create course in Studio
4. Open Settings -> Schedule & details
5. Once you enter this page, you shouldn't watch the warning popover to jump out as you just made a change
6. Additionally, in the Course overview it must be displayed the default images if the assets are not found

[openedx-webhooks]

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.51%. Comparing base (5c1cdcf) to head (fdbadd3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...rc/editors/sharedComponents/TinyMceWidget/hooks.ts	96.29%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #1708    +/-   ##
========================================
  Coverage   95.51%   95.51%            
========================================
  Files        1329     1330     +1     
  Lines       30544    30548     +4     
  Branches     6941     6706   -235     
========================================
+ Hits        29173    29178     +5     
- Misses       1303     1314    +11     
+ Partials       68       56    -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[arbrandes]

I think this is a reasonable approach to fix #1265. Thank you! I would like for it to use react-query, though, if at all possible.

[bra-i-am]

@arbrandes, I have already addressed your comment and modified the code to implement the fix using react-query.

I'm looking forward to your feedback! Thanks ✨

[arbrandes]

Thanks, @bra-i-am! I'm putting this back on my queue. I'll try to get to it before the conference, but it's possible I'll only be able to review or on after July 7th.

[mariajgrimaldi]

@bra-i-am: can you help us fix the branch conflicts? Thanks!

[mphilbrick211]

Hi @bra-i-am! Is this pull request still in progress?

[mphilbrick211]

Hi @bra-i-am! Is this pull request still in progress?

@arbrandes @bra-i-am friendly ping on this!

[bra-i-am]

@mphilbrick211, I solved some conflicts on this branch; the codecov/patch error this is displaying is from some minor spaces that I'll be addressing later. Please let me know if you notice anything else I need to attend to. Thanks, and sorry for the long delay

[mphilbrick211]

Thanks, @bra-i-am! @arbrandes are you able to take a look?

[mphilbrick211]

Hi @bra-i-am! Is this still in progress?

[arbrandes]

Array.foreach() does not wait for callbacks to resolve, so this is going to behave unpredictably. The fact that tests didn't catch this means the tests need to be improved.

I suggest you make replaceStaticWithAsset itself asynchronous, and then use for...of instead of foreach. Callers will need to await, of course.

[arbrandes]

I don't think there are global defaults for course details, right? This block can be removed.

[arbrandes]

This means that the data is only set on initial load, not after saving.

I suggest you expose dataUpdatedAt (a react query primitive) from the query hook, then depend on that here instead of isLoading.

[bra-i-am]

@arbrandes, I really appreciate your help reviewing this, and thanks for your feedback.

I just pushed some updates: I made the function replaceStaticWithAsset asynchronous, but because of this, I had to make some additional changes, which is why I created the custom hook.

Please let me know what you think about the changes.

Thanks again!

[mphilbrick211]

Flagging this for you, @arbrandes

[arbrandes]

Hi @bra-i-am, thanks for sticking with it! I unleashed Claude on the PR, and it seems there are a few more things to work on:

1. React-query metadata leaks into the save API payload (bug)

useGetCourseDetails returns { ...data, id, isLoading, isError, refetch, dataUpdatedAt }. This entire object is passed as initialEditedData to useSaveValuesPrompt, which stores it in editedValues state (hooks.jsx#L43, hooks.jsx#L53).

When the user saves, editedValues is sent to the PUT API endpoint via updateWithDefaultValues(editedValues) -> updateCourseDetails(courseId, details) -> convertObjectToSnakeCase(details). This means fields like is_loading, is_error, and data_updated_at are included in the request body. refetch (a function) would be dropped by JSON serialization, but the other fields would not.

Depending on the server's behavior, this could cause validation errors or silently pass unexpected data. At minimum, these fields should be stripped before editedValues is initialized.

A clean fix would be to separate the course details data from the react-query metadata in useGetCourseDetails, or to extract only the data fields when passing to useSaveValuesPrompt.

2. 403 handling regression for course details

Previously, a 403 response when fetching course details triggered a dedicated "denied" state (RequestStatus.DENIED) that rendered a <Placeholder /> component. The base version of index.jsx checked loadingDetailsStatus === RequestStatus.DENIED.

Now, useGetCourseDetails only exposes isError (true for any error - 403, 404, 500, etc.), and the denied check only covers loadingSettingsStatus. A 403 on course details will now show a generic "load failed" alert instead of the placeholder. This is a behavior regression.

To preserve the existing behavior, the react-query hook could check error.response.status === 403 and expose it separately, or react-query's meta/onError could be used to handle it.

3. Asset validation uses GET instead of HEAD

replaceStaticWithAsset calls getAuthenticatedHttpClient().get(staticFullUrl) to check whether an asset exists. For assets that could be large (images, PDFs), this downloads the entire file just to determine existence. The asset-serving view in edx-platform (contentserver/views.py) uses Django's @require_safe decorator, which supports HEAD requests. Using .head(staticFullUrl) instead of .get() would avoid transferring the response body.

4. Whitespace: tab character in apiHooks.ts

apiHooks.ts line 22 uses a tab for dataUpdatedAt indentation instead of spaces, inconsistent with the rest of the file.