Skip to content

Commit b25e60a

Browse files
committed
fix: solve test issues
1 parent 84fab47 commit b25e60a

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

src/grading-settings/GradingSettings.test.jsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -139,17 +139,14 @@ describe('<GradingSettings />', () => {
139139
});
140140

141141
describe('<GradingSettings /> permissions', () => {
142-
const setupMocks = () => {
142+
beforeEach(() => {
143+
jest.restoreAllMocks();
143144
const mocks = initializeMocks();
144145
Object.defineProperty(window, 'scrollTo', { value: jest.fn(), writable: true });
145146
const { axiosMock: mock } = mocks;
146147
mock.onGet(getGradingSettingsApiUrl(courseId)).reply(200, gradingSettings);
147148
mock.onPost(getGradingSettingsApiUrl(courseId)).reply(200, {});
148149
mock.onGet(getCourseSettingsApiUrl(courseId)).reply(200, {});
149-
return mock;
150-
};
151-
152-
beforeEach(() => {
153150
jest.mocked(useUserPermissionsWithAuthzCourse).mockReturnValue({
154151
isLoading: false,
155152
permissions: { canViewGradingSettings: true, canEditGradingSettings: true },
@@ -158,14 +155,12 @@ describe('<GradingSettings /> permissions', () => {
158155

159156
it('should render normally when authz flag is disabled (no regression)', async () => {
160157
mockWaffleFlags({ enableAuthzCourseAuthoring: false });
161-
setupMocks();
162158
render(<RootWrapper />);
163159
expect(await screen.findAllByText(messages.headingTitle.defaultMessage)).not.toHaveLength(0);
164160
});
165161

166162
it('should render normally when user has view and edit permissions', async () => {
167163
mockWaffleFlags({ enableAuthzCourseAuthoring: true });
168-
setupMocks();
169164
render(<RootWrapper />);
170165
expect(await screen.findAllByText(messages.headingTitle.defaultMessage)).not.toHaveLength(0);
171166
});
@@ -176,7 +171,6 @@ describe('<GradingSettings /> permissions', () => {
176171
isLoading: false,
177172
permissions: { canViewGradingSettings: false, canEditGradingSettings: false },
178173
});
179-
setupMocks();
180174
render(<RootWrapper />);
181175
expect(await screen.findByTestId('permissionDeniedAlert')).toBeInTheDocument();
182176
});
@@ -187,7 +181,6 @@ describe('<GradingSettings /> permissions', () => {
187181
isLoading: false,
188182
permissions: { canViewGradingSettings: true, canEditGradingSettings: false },
189183
});
190-
setupMocks();
191184
render(<RootWrapper />);
192185
const segmentInputs = await screen.findAllByTestId('grading-scale-segment-input');
193186
segmentInputs.forEach((input) => expect(input).toBeDisabled());
@@ -199,7 +192,6 @@ describe('<GradingSettings /> permissions', () => {
199192
isLoading: false,
200193
permissions: { canViewGradingSettings: true, canEditGradingSettings: false },
201194
});
202-
setupMocks();
203195
render(<RootWrapper />);
204196
const segmentInputs = await screen.findAllByTestId('grading-scale-segment-input');
205197
// Trigger a change to show the save alert

0 commit comments

Comments
 (0)