fix: use default params instead of defaultProps for new props, add permission tests

Author: bra-i-am

src/grading-settings/GradingSettings.test.jsx

@@ -3,13 +3,25 @@ import {
 } from '@src/testUtils';
 import { CourseAuthoringProvider } from '@src/CourseAuthoringContext';
 import { getCourseSettingsApiUrl } from '@src/data/api';
+import { mockWaffleFlags } from '@src/data/apiHooks.mock';
+import { useUserPermissionsWithAuthzCourse } from '@src/authz/hooks';
 
 import gradingSettings from './__mocks__/gradingSettings';
 import { getGradingSettingsApiUrl } from './data/api';
 import * as apiHooks from './data/apiHooks';
 import GradingSettings from './GradingSettings';
 import messages from './messages';
 
+jest.mock('@src/authz/hooks', () => ({
+  useUserPermissionsWithAuthzCourse: jest.fn().mockReturnValue({
+    isLoading: false,
+    permissions: {
+      canViewGradingSettings: true,
+      canEditGradingSettings: true,
+    },
+  }),
+}));
+
 const courseId = '123';
 let axiosMock;
 
@@ -125,3 +137,74 @@ describe('<GradingSettings />', () => {
     expect(screen.getByTestId('connectionErrorAlert')).toBeInTheDocument();
   });
 });
+
+describe('<GradingSettings /> permissions', () => {
+  const setupMocks = () => {
+    const mocks = initializeMocks();
+    Object.defineProperty(window, 'scrollTo', { value: jest.fn(), writable: true });
+    const { axiosMock: mock } = mocks;
+    mock.onGet(getGradingSettingsApiUrl(courseId)).reply(200, gradingSettings);
+    mock.onPost(getGradingSettingsApiUrl(courseId)).reply(200, {});
+    mock.onGet(getCourseSettingsApiUrl(courseId)).reply(200, {});
+    return mock;
+  };
+
+  beforeEach(() => {
+    jest.mocked(useUserPermissionsWithAuthzCourse).mockReturnValue({
+      isLoading: false,
+      permissions: { canViewGradingSettings: true, canEditGradingSettings: true },
+    });
+  });
+
+  it('should render normally when authz flag is disabled (no regression)', async () => {
+    mockWaffleFlags({ enableAuthzCourseAuthoring: false });
+    setupMocks();
+    render(<RootWrapper />);
+    expect(await screen.findAllByText(messages.headingTitle.defaultMessage)).not.toHaveLength(0);
+  });
+
+  it('should render normally when user has view and edit permissions', async () => {
+    mockWaffleFlags({ enableAuthzCourseAuthoring: true });
+    setupMocks();
+    render(<RootWrapper />);
+    expect(await screen.findAllByText(messages.headingTitle.defaultMessage)).not.toHaveLength(0);
+  });
+
+  it('should show permission denied alert when user lacks view permission', async () => {
+    mockWaffleFlags({ enableAuthzCourseAuthoring: true });
+    jest.mocked(useUserPermissionsWithAuthzCourse).mockReturnValue({
+      isLoading: false,
+      permissions: { canViewGradingSettings: false, canEditGradingSettings: false },
+    });
+    setupMocks();
+    render(<RootWrapper />);
+    expect(await screen.findByTestId('permissionDeniedAlert')).toBeInTheDocument();
+  });
+
+  it('should disable inputs when user has view but not edit permission', async () => {
+    mockWaffleFlags({ enableAuthzCourseAuthoring: true });
+    jest.mocked(useUserPermissionsWithAuthzCourse).mockReturnValue({
+      isLoading: false,
+      permissions: { canViewGradingSettings: true, canEditGradingSettings: false },
+    });
+    setupMocks();
+    render(<RootWrapper />);
+    const segmentInputs = await screen.findAllByTestId('grading-scale-segment-input');
+    segmentInputs.forEach((input) => expect(input).toBeDisabled());
+  });
+
+  it('should disable save button when user lacks edit permission', async () => {
+    mockWaffleFlags({ enableAuthzCourseAuthoring: true });
+    jest.mocked(useUserPermissionsWithAuthzCourse).mockReturnValue({
+      isLoading: false,
+      permissions: { canViewGradingSettings: true, canEditGradingSettings: false },
+    });
+    setupMocks();
+    render(<RootWrapper />);
+    const segmentInputs = await screen.findAllByTestId('grading-scale-segment-input');
+    // Trigger a change to show the save alert
+    fireEvent.change(segmentInputs[1], { target: { value: 'Test' } });
+    const saveBtn = screen.getByTestId('grading-settings-save-alert').querySelector('button[type="button"]:last-child');
+    expect(saveBtn).toBeDisabled();
+  });
+});

src/grading-settings/assignment-section/assignments/AssignmentItem.jsx

@@ -20,7 +20,7 @@ const AssignmentItem = ({
   secondErrorMsg,
   gradeField,
   trailingElement,
-  disabled,
+  disabled = false,
 }) => (
   <li className={className}>
     <Form.Group className={classNames('form-group-custom', {
@@ -66,7 +66,6 @@ AssignmentItem.defaultProps = {
   errorEffort: false,
   gradeField: undefined,
   trailingElement: undefined,
-  disabled: false,
 };
 
 AssignmentItem.propTypes = {

src/grading-settings/assignment-section/assignments/AssignmentTypeName.jsx

@@ -11,7 +11,7 @@ const AssignmentTypeName = ({
   value,
   errorEffort,
   onChange,
-  disabled,
+  disabled = false,
 }) => {
   const intl = useIntl();
   const initialAssignmentName = useRef(value);
@@ -62,7 +62,6 @@ const AssignmentTypeName = ({
 
 AssignmentTypeName.defaultProps = {
   errorEffort: false,
-  disabled: false,
 };
 
 AssignmentTypeName.propTypes = {

src/grading-settings/assignment-section/index.jsx

@@ -22,7 +22,7 @@ const AssignmentSection = ({
   setGradingData,
   courseAssignmentLists,
   setShowSuccessAlert,
-  isEditable,
+  isEditable = true,
 }) => {
   const intl = useIntl();
   const [errorList, setErrorList] = useState({});
@@ -206,7 +206,6 @@ const AssignmentSection = ({
 AssignmentSection.defaultProps = {
   courseAssignmentLists: undefined,
   graders: undefined,
-  isEditable: true,
 };
 
 AssignmentSection.propTypes = {

src/grading-settings/credit-section/index.jsx

@@ -12,7 +12,7 @@ const CreditSection = ({
   minimumGradeCredit,
   setGradingData,
   setShowSuccessAlert,
-  isEditable,
+  isEditable = true,
 }) => {
   const intl = useIntl();
   const [errorEffort, setErrorEffort] = useState(false);
@@ -66,10 +66,6 @@ const CreditSection = ({
   );
 };
 
-CreditSection.defaultProps = {
-  isEditable: true,
-};
-
 CreditSection.propTypes = {
   eligibleGrade: PropTypes.number.isRequired,
   setShowSavePrompt: PropTypes.func.isRequired,

src/grading-settings/deadline-section/index.jsx

@@ -9,7 +9,7 @@ import { formatTime, timerValidation } from './utils';
 import messages from './messages';
 
 const DeadlineSection = ({
-  setShowSavePrompt, gracePeriod, setGradingData, setShowSuccessAlert, isEditable,
+  setShowSavePrompt, gracePeriod, setGradingData, setShowSuccessAlert, isEditable = true,
 }) => {
   const intl = useIntl();
   const timeStampValue = gracePeriod
@@ -69,7 +69,6 @@ const DeadlineSection = ({
 
 DeadlineSection.defaultProps = {
   gracePeriod: null,
-  isEditable: true,
 };
 
 DeadlineSection.propTypes = {

src/grading-settings/grading-scale/GradingScale.jsx

@@ -23,7 +23,7 @@ const GradingScale = ({
   setOverrideInternetConnectionAlert,
   setEligibleGrade,
   defaultGradeDesignations,
-  isEditable,
+  isEditable = true,
 }) => {
   const intl = useIntl();
   const [gradingSegments, setGradingSegments] = useState(sortedGrades);
@@ -267,7 +267,6 @@ GradingScale.propTypes = {
 
 GradingScale.defaultProps = {
   defaultGradeDesignations: DEFAULT_GRADE_LETTERS,
-  isEditable: true,
 };
 
 export default GradingScale;

src/grading-settings/grading-scale/components/GradingScaleHandle.jsx

@@ -4,7 +4,7 @@ import PropTypes from 'prop-types';
 import { MAXIMUM_SCALE_LENGTH } from '../utils';
 
 const GradingScaleHandle = ({
-  idx, value, gradingSegments, getHandleProps, isEditable,
+  idx, value, gradingSegments, getHandleProps, isEditable = true,
 }) => (
   <button
     key={value}
@@ -19,10 +19,6 @@ const GradingScaleHandle = ({
   />
 );
 
-GradingScaleHandle.defaultProps = {
-  isEditable: true,
-};
-
 GradingScaleHandle.propTypes = {
   idx: PropTypes.number.isRequired,
   value: PropTypes.number.isRequired,