fixing base breadcrumb item with no link set#32
fixing base breadcrumb item with no link set#32brian-smith-tcril merged 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1155bc2 to
ecbda70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 94.32% 94.33% +0.01%
==========================================
Files 44 44
Lines 881 883 +2
Branches 176 155 -21
==========================================
+ Hits 831 833 +2
Misses 48 48
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @dcoa, I noticed there are some custom styles overriding the defaults for the first item on the breadcrumb, I did not find the figma design for the breadcrumb. What's the reason for this style override? |
As you can see in the original design, the "Manage Access" is always displayed as a static (no-actionable item).
The intention overriding the styles was simulate that static behavior (because there was no page to redirect) Now, I feel that if a link needs to be added then the default styles should be displayed to keep the look and feel of the website. |
ecbda70 to
6273610
Compare
6273610 to
ab55031
Compare
Sure now that it has a url it make sense to look like a normal link , I am removing those custom styles so the breadcrumb link can have the defaults from paragon, thanks. |
dcoa
left a comment
There was a problem hiding this comment.
LGTM! Thank you!!
@brian-smith-tcril @arbrandes could you please have a look on this small fix.




Description
Adding url link to “Manage Access” breadcrumb item and adding unit test to support this modification.
It closes #29
Demo video
Grabacion.de.pantalla.2025-11-04.a.la.s.2.24.01.p.m.mov
How to test it
npm install && npm run devhttp://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>Editlink on one of the users in the team members table or go tohttp://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>/<username>Manage Accessitem on the breadcrumb.http://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>page