Skip to content

fixing base breadcrumb item with no link set#32

Merged
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:breadcrumb-issue
Nov 5, 2025
Merged

fixing base breadcrumb item with no link set#32
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:breadcrumb-issue

Conversation

@jacobo-dominguez-wgu
Copy link
Copy Markdown
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Nov 4, 2025

Description

Adding url link to “Manage Access” breadcrumb item and adding unit test to support this modification.
It closes #29

Demo video

Grabacion.de.pantalla.2025-11-04.a.la.s.2.24.01.p.m.mov

How to test it

  • npm install && npm run dev
  • Go to http://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>
  • Click on the Edit link on one of the users in the team members table or go to http://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>/<username>
  • Click on the Manage Access item on the breadcrumb.
  • It must take you back to the http://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID> page

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.33%. Comparing base (a0dc22c) to head (ab55031).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   94.32%   94.33%   +0.01%     
==========================================
  Files          44       44              
  Lines         881      883       +2     
  Branches      176      155      -21     
==========================================
+ Hits          831      833       +2     
  Misses         48       48              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu
Copy link
Copy Markdown
Contributor Author

Hi @dcoa, I noticed there are some custom styles overriding the defaults for the first item on the breadcrumb, I did not find the figma design for the breadcrumb. What's the reason for this style override?

@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Nov 4, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Ready for Review in Contributions Nov 4, 2025
Comment thread src/authz-module/libraries-manager/LibrariesTeamManager.tsx
@dcoa
Copy link
Copy Markdown
Contributor

dcoa commented Nov 4, 2025

Hi @dcoa, I noticed there are some custom styles overriding the defaults for the first item on the breadcrumb, I did not find the figma design for the breadcrumb. What's the reason for this style override?

As you can see in the original design, the "Manage Access" is always displayed as a static (no-actionable item).

image image

The intention overriding the styles was simulate that static behavior (because there was no page to redirect)

Now, I feel that if a link needs to be added then the default styles should be displayed to keep the look and feel of the website.

@jacobo-dominguez-wgu
Copy link
Copy Markdown
Contributor Author

jacobo-dominguez-wgu commented Nov 4, 2025

Hi @dcoa, I noticed there are some custom styles overriding the defaults for the first item on the breadcrumb, I did not find the figma design for the breadcrumb. What's the reason for this style override?

As you can see in the original design, the "Manage Access" is always displayed as a static (no-actionable item).

image image
The intention overriding the styles was simulate that static behavior (because there was no page to redirect)

Now, I feel that if a link needs to be added then the default styles should be displayed to keep the look and feel of the website.

Sure now that it has a url it make sense to look like a normal link , I am removing those custom styles so the breadcrumb link can have the defaults from paragon, thanks.

Copy link
Copy Markdown
Contributor

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!

@brian-smith-tcril @arbrandes could you please have a look on this small fix.

Copy link
Copy Markdown

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brian-smith-tcril brian-smith-tcril merged commit b760584 into openedx:master Nov 5, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: Breadcrumb “Manage Access” does not navigate, reloads same screen

5 participants