refactor: remove libraries routes and libraries-manager module#148
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 97.46% 97.64% +0.17%
==========================================
Files 89 68 -21
Lines 2133 1572 -561
Branches 461 394 -67
==========================================
- Hits 2079 1535 -544
+ Misses 52 37 -15
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…odule - Delete entire src/authz-module/libraries-manager/ directory - Remove LIBRARIES_USER_PATH and LIBRARIES_TEAM_PATH from ROUTES - Move ErrorPage component to src/authz-module/components/ErrorPage/ (still used as the module-level error boundary fallback) - Update index.tsx imports and remove library route definitions - Remove library-related test cases from index.test.tsx
59df9ff to
8baf934
Compare
jesusbalderramawgu
left a comment
There was a problem hiding this comment.
This is a great cleanup, thank you!
Description
Removed the libraries manager module and all of its codebase under the paths
/libraries/:libraryIdand/libraries/:libraryId/:username.Closes #136