Skip to content

fix: redirecting to team members when there are not roles left after removing the last one#146

Merged
jacobo-dominguez-wgu merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:removing-role-fixes
Apr 27, 2026
Merged

fix: redirecting to team members when there are not roles left after removing the last one#146
jacobo-dominguez-wgu merged 1 commit intoopenedx:masterfrom
WGU-Open-edX:removing-role-fixes

Conversation

@jacobo-dominguez-wgu
Copy link
Copy Markdown
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Apr 27, 2026

Description

Adding validation to redirect to team members table after being on the audit user page and removing the last assigned role to the user.

Scenario: Removing the last role redirects to Team Members
Given I open the audit view for a user with only one role assignment
When I click the trash icon and confirm
Then a success toast appears, I am redirected to the Team Members table, and the user no longer appears there

It closes #147

Demo

Grabacion.de.pantalla.2026-04-27.a.la.s.11.02.53.a.m.mov

How to test it

  1. Go to a specific user page with roles assigned http://apps.local.openedx.io:2025/admin-console/authz/user/:userId
  2. Remove all the roles assigned.
  3. Once the last role is removed, it must redirect to the team members view.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 27, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (bceb3c0) to head (509dfff).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   97.46%   97.47%           
=======================================
  Files          89       89           
  Lines        2133     2135    +2     
  Branches      461      462    +1     
=======================================
+ Hits         2079     2081    +2     
  Misses         52       52           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu changed the title fix: redirecting to home when there are not roles pending after removal fix: redirecting to team members when there are not roles left after removing the last one Apr 27, 2026
Copy link
Copy Markdown

@rodmgwgu rodmgwgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected, thanks for the quick turnaround!

@jacobo-dominguez-wgu jacobo-dominguez-wgu merged commit 901173e into openedx:master Apr 27, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

When on the audit user view the last assigned role is removed I am redirected to the Team Members table

4 participants