feat(authz): expand permissions view by jesusbalderramawgu · Pull Request #125 · openedx/frontend-app-admin-console

jesusbalderramawgu · 2026-03-31T15:35:01Z

Description

this PR closes this task
this needs to be reviewed once Jacobo's PR is merged
includes code from

Update this PR has been merged

openedx-webhooks · 2026-03-31T15:35:08Z

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-04-19T20:08:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (f1371b8) to head (f2839a1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   96.13%   96.20%   +0.07%     
==========================================
  Files          76       81       +5     
  Lines        1783     1869      +86     
  Branches      351      418      +67     
==========================================
+ Hits         1714     1798      +84     
- Misses         67       68       +1     
- Partials        2        3       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jesusbalderramawgu · 2026-04-19T21:50:12Z

I rebased this branch with the latest, made a minor fixes and added the proper tests.
is ready for review, could you please take a look @dcoa

rodmgwgu · 2026-04-20T19:05:53Z

I see some diferencies with the Figma design related to Global Staff, roles, I see that in the design, these roles are highlighted in gray, and show "Partial Access" under Permissions instead of "0 permissions available" as it's now.

Also, there seems to be some extra space at the bottom of the message for these cases that shouldn't be there.

Figma:

Implementation:

jacobo-dominguez-wgu · 2026-04-20T19:20:57Z

+
+type CellProps = ExpandableTableRow<UserRole>;
+
+export const ViewAllPermissionsCell = ({ row }: CellProps) => {


Move the components on this file to src/authz-module/components/TableCells.tsx to have all the custom table cells in the same place.

jacobo-dominguez-wgu · 2026-04-20T19:26:23Z

@@ -0,0 +1,24 @@
+import { useIntl } from '@edx/frontend-platform/i18n';


Could you move all the subcomponents created inside src/authz-module/audit-user folder into src/authz-module/audit-user/components/ so it looks more organized?

Thank you, I have updated this also I moved the components from the CustomCells component to TableCells component

jacobo-dominguez-wgu · 2026-04-20T19:27:00Z

@@ -1,5 +1,5 @@
 import { renderHook, act } from '@testing-library/react';
-import { QuerySettings } from '@src/authz-module/data/api';
+import { QuerySettings } from '../data/api';


I think it was better to use the absolute path for the import.

jacobo-dominguez-wgu · 2026-04-20T19:27:08Z

@@ -1,5 +1,5 @@
 import { useCallback, useState } from 'react';
-import { QuerySettings } from '@src/authz-module/data/api';
+import { QuerySettings } from '../data/api';


jesusbalderramawgu · 2026-04-20T20:39:55Z

I see some diferencies with the Figma design related to Global Staff, roles, I see that in the design, these roles are highlighted in gray, and show "Partial Access" under Permissions instead of "0 permissions available" as it's now.

Also, there seems to be some extra space at the bottom of the message for these cases that shouldn't be there.

Figma:

Implementation:

thank you @rodmgwgu this has been fixed, the background stopped working due to another PR

rodmgwgu

Thanks for this work, I requested some changes on details I found.

rodmgwgu · 2026-04-20T21:19:35Z

 import { useQuerySettings } from '@src/authz-module/hooks/useQuerySettings';
 import { useUserAssignedRoles } from '@src/authz-module/data/hooks';
 import messages from './messages';
+import UserPermissions from '../components/UserPermissions';


Should we use absolute imports here?

this has been fixed!

rodmgwgu · 2026-04-20T21:20:11Z

+  libraryPermissions,
+  rolesLibraryObject,
+} from '../libraries/constants';
+import RenderPermissionColumn from '../components/RenderPermissionColumn';


Same in these, I'm not sure what's the project standard.

this has been fixed!

rodmgwgu · 2026-04-20T21:20:42Z

@@ -0,0 +1,22 @@
+import { useIntl } from '@edx/frontend-platform/i18n';
+import messages from '../audit-user/messages';


this has been fixed!

rodmgwgu · 2026-04-20T21:24:48Z

@@ -0,0 +1,95 @@
+import { DJANGO_MANAGED_ROLES } from '@src/authz-module/constants';


I see this file (UserPermissions.tsx) also exists under components, and this one seems to not be used, please remove if not needed.

this has been fixed!

rodmgwgu · 2026-04-20T21:25:11Z

This file is empty, do we need it?

not anymore I have removed it

rodmgwgu · 2026-04-20T21:27:41Z

+      const expanded = (instance as any)?.state?.expanded || {};
+      Object.keys(expanded).forEach(rowId => {
+        if (rowId !== row.id && expanded[rowId]) {
+          (instance as any).toggleRowExpanded?.(rowId, false);


Could we avoid using any here? this may silently break in the future if the Paragon DataTable changes in the future.

thank you! I made the change!

rodmgwgu · 2026-04-20T21:28:10Z

+      description: 'Description for the permissions of the Super Admin role',
+    },
+    'authz.user.table.permissions.role.staff': {
+      id: 'authz.user.table.permissions.role.staff ',


There is a trailing whitespace here, I guess it shouldn't be here.

this has been fixed!

rodmgwgu · 2026-04-20T21:31:32Z

+  },
+];
+
+export const DEFAULT_TOAST_DELAY = 5000;


These constants seem to be repeated in libraries/constants and in src/authz-module/constants.ts, let's have them in just one place.

this has been fixed!

rodmgwgu · 2026-04-20T21:33:05Z

  queryFn: async () => getUserAccount(username),
  retry: false,
  enabled: !!username,
-  refetchOnWindowFocus: false,


Was this change intentional? usually we don't want to refetch user information on every focus.

bra-i-am

It works as expected, and I see the code fine! I mainly point to the texts, but I think they are going to be received translated from the backend in the future, aren't they?

Additionally, I think it would be cool if the cursor were pointer on ViewMoreLink hover, and avoid the text 0 permissions available when the user has Global scope permissions, as it is contradictory.

Isn't this going to be added by now?

bra-i-am · 2026-04-20T20:04:34Z

I saw there is similar data at src/frontend-app-admin-console/src/authz-module/roles-permissions/courses/constants.ts

are we going to delete that file in favor of this?

bra-i-am · 2026-04-20T20:27:25Z

+  {
+    key: CONTENT_COURSE_PERMISSIONS.EDIT_COURSE_FILES,
+    resource: 'course_files',
+    description: 'Permanently remove files and assets from the course.',


Suggested change

description: 'Permanently remove files and assets from the course.',

description: 'Perform non-destructive actions on files, such as locking or unlocking them.',

bra-i-am · 2026-04-20T20:27:57Z

+    key: CONTENT_LIBRARY_PERMISSIONS.EDIT_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Publish', description: 'Update the name and contents of existing collections.', icon: EditOutline,
+  },
+  {
+    key: CONTENT_LIBRARY_PERMISSIONS.DELETE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Edit', description: 'Permanently remove collections from the library.', icon: EditOutline,


Suggested change

key: CONTENT_LIBRARY_PERMISSIONS.DELETE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Edit', description: 'Permanently remove collections from the library.', icon: EditOutline,

key: CONTENT_LIBRARY_PERMISSIONS.DELETE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Delete', description: 'Permanently remove collections from the library.', icon: Delete,

bra-i-am · 2026-04-20T20:33:18Z

+  {
+    key: CONTENT_COURSE_PERMISSIONS.MANAGE_COURSE_CERTIFICATES,
+    resource: 'course_advanced_certificates',
+    description: 'Access and edit the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',


Suggested change

description: 'Access and edit the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',

description: 'Create and edit course certificates, including certificate design and eligibility settings.',

bra-i-am · 2026-04-20T20:36:09Z

+  {
+    key: CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_DETAILS,
+    resource: 'course_schedule_details',
+    description: 'See course information including the course summary, pacing, and prerequisites..',


Suggested change

description: 'See course information including the course summary, pacing, and prerequisites..',

description: 'See course information including the course summary, pacing, and prerequisites.',

bra-i-am · 2026-04-20T20:37:59Z

+  {
+    key: CONTENT_COURSE_PERMISSIONS.DELETE_COURSE_FILES,
+    resource: 'course_files',
+    description: 'Delete files.',


Suggested change

description: 'Delete files.',

description: 'Permanently remove files and assets from the course.',

bra-i-am · 2026-04-20T20:39:42Z

+    key: CONTENT_LIBRARY_PERMISSIONS.MANAGE_LIBRARY_TEAM, resource: 'library_team', label: 'Manage', description: 'Add, change, or remove role assignments for this library from the Roles and Permissions console.', icon: Settings,
+  },
+  {
+    key: CONTENT_LIBRARY_PERMISSIONS.CREATE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'View', description: 'Create new collections to organize content within the library.', icon: RemoveRedEye,


Suggested change

key: CONTENT_LIBRARY_PERMISSIONS.CREATE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'View', description: 'Create new collections to organize content within the library.', icon: RemoveRedEye,

key: CONTENT_LIBRARY_PERMISSIONS.CREATE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Create', description: 'Create new collections to organize content within the library.', icon: RemoveRedEye,

bra-i-am · 2026-04-20T20:40:03Z

+    key: CONTENT_LIBRARY_PERMISSIONS.CREATE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'View', description: 'Create new collections to organize content within the library.', icon: RemoveRedEye,
+  },
+  {
+    key: CONTENT_LIBRARY_PERMISSIONS.EDIT_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Publish', description: 'Update the name and contents of existing collections.', icon: EditOutline,


Suggested change

key: CONTENT_LIBRARY_PERMISSIONS.EDIT_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Publish', description: 'Update the name and contents of existing collections.', icon: EditOutline,

key: CONTENT_LIBRARY_PERMISSIONS.EDIT_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Edit', description: 'Update the name and contents of existing collections.', icon: EditOutline,

bra-i-am · 2026-04-20T20:41:58Z

+  {
+    key: CONTENT_COURSE_PERMISSIONS.MANAGE_COURSE_ADVANCED_SETTINGS,
+    resource: 'course_advanced_certificates',
+    description: 'Access and edit the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options..',


Suggested change

description: 'Access and edit the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options..',

description: 'Access and edit the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',

bra-i-am · 2026-04-20T20:58:38Z

-@import "~@edx/frontend-component-header/dist/index";
+@use "@openedx/paragon/dist/core.min.css";
+@use "@openedx/paragon/dist/light.min.css";
+@import "~@edx/frontend-component-header/dist/index";


Suggested change

@import "~@edx/frontend-component-header/dist/index";

@import "~@edx/frontend-component-header/dist/index";

jesusbalderramawgu · 2026-04-20T22:44:53Z

It works as expected, and I see the code fine! I mainly point to the texts, but I think they are going to be received translated from the backend in the future, aren't they?

Additionally, I think it would be cool if the cursor were pointer on ViewMoreLink hover, and avoid the text 0 permissions available when the user has Global scope permissions, as it is contradictory.

Isn't this going to be added by now?

Thank you @bra-i-am I have addressed your comments, I just didn't change the texts because the ones that I have right now were specified in the task

jacobo-dominguez-wgu

LGTM and works as expected!

jacobo-dominguez-wgu · 2026-04-20T23:34:18Z

@bra-i-am, @rodmgwgu do you wanna make another review before merging?

rodmgwgu

Thanks!

…vements on the header

jesusbalderramawgu marked this pull request as draft March 31, 2026 15:35

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 31, 2026

openedx-webhooks added this to Contributions Mar 31, 2026

github-project-automation Bot moved this to Needs Triage in Contributions Mar 31, 2026

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 1, 2026

mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Apr 1, 2026

jesusbalderramawgu force-pushed the feature/expanded-permissions-view branch 2 times, most recently from 7708f60 to 979521b Compare April 19, 2026 19:07

jesusbalderramawgu requested a review from dcoa April 19, 2026 21:48

jesusbalderramawgu marked this pull request as ready for review April 19, 2026 21:50

mariajgrimaldi requested review from bra-i-am and jacobo-dominguez-wgu April 20, 2026 17:17

rodmgwgu requested a review from diana-villalvazo-wgu April 20, 2026 19:07

jacobo-dominguez-wgu reviewed Apr 20, 2026

View reviewed changes

rodmgwgu suggested changes Apr 20, 2026

View reviewed changes

bra-i-am suggested changes Apr 20, 2026

View reviewed changes

jesusbalderramawgu requested review from bra-i-am, jacobo-dominguez-wgu and rodmgwgu April 20, 2026 23:33

jacobo-dominguez-wgu approved these changes Apr 20, 2026

View reviewed changes

rodmgwgu approved these changes Apr 21, 2026

View reviewed changes

jacobo-dominguez-wgu and others added 25 commits April 21, 2026 10:26

refactor: moving files from libraries to authz module and minor impro…

92b57e8

…vements on the header

feat: roles table for audit user page

6bd20a9

feat: expanded row view for user roles added

d31bf6e

chore: border color updated

80685fa

chore: styles and texts adjusted

97b916d

feat: refactor to handle the table accordion correctly after rebase

151174d

fix: column width fixed

eacd9ee

fix: imports fix

d2ce422

feat: functionality to keep one accordion open

8a5cf69

fix: lint and tests fixed

068ebfb

feat: missing tests added to get coverage

d867030

chore: unnecessary container removed

6486da0

chore: removed space

0cd3d65

fix: fix in container

a67a7b8

feat: missing test added

8647ea4

fix: labels and styles adjusted to match with design

6bc59dc

chore: refactor to avoid duplicated code

f4e1d8e

fix: refactor of TableCells component

4262dd0

chore: refactor of files path for better organization

0a6ce84

chore: unnecessary code removed and fix and imports

08af990

fix: refetchOnWindowFocus added

d586e7e

fix: constants file merged, fix in imports and texts

a024561

fix: height added to avoid a paragon bug with dropdown

071f872

fix: tests fixed

6dfacb9

fix: missing test added

0f4610a

jesusbalderramawgu force-pushed the feature/expanded-permissions-view branch from 16022e5 to 0f4610a Compare April 21, 2026 16:29

chore: remove height class

f2839a1

jacobo-dominguez-wgu merged commit 0d4f93e into openedx:master Apr 21, 2026
6 checks passed

github-project-automation Bot moved this from Waiting on Author to Done in Contributions Apr 21, 2026


		type CellProps = ExpandableTableRow<UserRole>;

		export const ViewAllPermissionsCell = ({ row }: CellProps) => {

		@@ -0,0 +1,24 @@
		import { useIntl } from '@edx/frontend-platform/i18n';

		@@ -0,0 +1,22 @@
		import { useIntl } from '@edx/frontend-platform/i18n';
		import messages from '../audit-user/messages';

		@@ -0,0 +1,95 @@
		import { DJANGO_MANAGED_ROLES } from '@src/authz-module/constants';

	description: 'Permanently remove files and assets from the course.',
	description: 'Perform non-destructive actions on files, such as locking or unlocking them.',

	key: CONTENT_LIBRARY_PERMISSIONS.DELETE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Edit', description: 'Permanently remove collections from the library.', icon: EditOutline,
	key: CONTENT_LIBRARY_PERMISSIONS.DELETE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Delete', description: 'Permanently remove collections from the library.', icon: Delete,

	description: 'Access and edit the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',
	description: 'Create and edit course certificates, including certificate design and eligibility settings.',

	description: 'See course information including the course summary, pacing, and prerequisites..',
	description: 'See course information including the course summary, pacing, and prerequisites.',

	description: 'Delete files.',
	description: 'Permanently remove files and assets from the course.',

	key: CONTENT_LIBRARY_PERMISSIONS.CREATE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'View', description: 'Create new collections to organize content within the library.', icon: RemoveRedEye,
	key: CONTENT_LIBRARY_PERMISSIONS.CREATE_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Create', description: 'Create new collections to organize content within the library.', icon: RemoveRedEye,

	key: CONTENT_LIBRARY_PERMISSIONS.EDIT_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Publish', description: 'Update the name and contents of existing collections.', icon: EditOutline,
	key: CONTENT_LIBRARY_PERMISSIONS.EDIT_LIBRARY_COLLECTION, resource: 'library_collection', label: 'Edit', description: 'Update the name and contents of existing collections.', icon: EditOutline,

	@import "~@edx/frontend-component-header/dist/index";
	@import "~@edx/frontend-component-header/dist/index";

Conversation

jesusbalderramawgu commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openedx-webhooks commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jesusbalderramawgu commented Apr 19, 2026

Uh oh!

rodmgwgu commented Apr 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu commented Apr 20, 2026

Uh oh!

rodmgwgu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodmgwgu Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bra-i-am left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu commented Mar 31, 2026 •

edited

Loading

openedx-webhooks commented Mar 31, 2026 •

edited

Loading

codecov Bot commented Apr 19, 2026 •

edited

Loading

rodmgwgu Apr 20, 2026 •

edited

Loading