test(realtime): cover multiple JSON tool outputs#3139
Closed
adityasingh2400 wants to merge 1 commit intoopenai:mainfrom
Closed
test(realtime): cover multiple JSON tool outputs#3139adityasingh2400 wants to merge 1 commit intoopenai:mainfrom
adityasingh2400 wants to merge 1 commit intoopenai:mainfrom
Conversation
Add regression coverage showing chained realtime tool calls returning structured JSON each request a follow-up response, guarding the voice-output path reported in openai#1168.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
|
The existing tests already cover these scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_response=True, guarding the voice follow-up path reported in Realtime API with Multiple Tool Calls Results in No Voice Output #1168.Covers #1168
Test plan
uv run ruff format tests/realtime/test_session.pyuv run ruff check tests/realtime/test_session.pyuv run pytest tests/realtime/test_session.py::TestToolCallExecution::test_multiple_json_tool_outputs_each_request_follow_up_response -quv run pytest tests/realtime/test_session.py -quv run mypy tests/realtime/test_session.pymake lint