[codex] support hook input rewrites#21302
Draft
abhinav-oai wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hooks can currently inspect tool input, but callers cannot safely substitute a rewritten payload while preserving the approval semantics around that new payload. That leaves sanitizing or normalizing hook workflows unable to change what actually runs.
What
updatedInputsupport forPreToolUseandPermissionRequesthook outputs.PreToolUserewrites carryalloworasksemantics into shell, apply_patch, unified exec, and MCP execution paths.PermissionRequestrewrites replace the full input, then re-enter normal approval evaluation so rewritten input is checked again before execution.Validation
cargo test -p codex-hookscargo test -p codex-core --lib mcp_tool_call::tests::permission_request_hook_can_update_mcp_tool_inputcargo test -p codex-core --test all suite::hooks::permission_request_hook_rewrites_shell_command_before_execution -- --exactcargo test -p codex-core --test all suite::hooks::permission_request_hook_rechecks_rewritten_shell_command -- --exactcargo test -p codex-core --test all suite::hooks::pre_tool_use_rewrites_shell_command_before_execution -- --exactjust fmtjust fix -p codex-corejust fix -p codex-hookscargo test -p codex-core --libwas also attempted; it aborted in the existingtools::handlers::multi_agents::tests::multi_agent_v2_close_agent_accepts_task_name_targettest with a stack overflow unrelated to this change.