Move skills watcher to app-server#21287
Open
pakrym-oai wants to merge 1 commit intomainfrom
Open
Conversation
pakrym-oai
force-pushed
the
pakrym/skills-update-available-app-server
branch
from
a2b383e to
6fcdafd
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fcdafdc15
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
May 6, 2026
opencode/codex/litellm coverage: - anomalyco/opencode#25962 desktop utilityProcess split (man) - openai/codex#21287 skills watcher hoisted to app-server (man) - BerriAI/litellm#27272 bounded prometheus end-user series tracker (man) - BerriAI/litellm#27278 GCS extensionless URI MIME resolution (man)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Skills update notifications are app-server API behavior, but the watcher lived in
codex-coreand surfaced throughEventMsg::SkillsUpdateAvailable. Moving the watcher out keeps core focused on thread execution and lets app-server own both cache invalidation and theskills/changednotification.What changed
skills/changeddirectly.WatchRegistrationonThreadState, so listener replacement, thread teardown, idle unload, and app-server shutdown deregister by dropping the RAII guard.EventMsg::SkillsUpdateAvailable, the core watcher, and the old core live-reload test.Validation
cargo check -p codex-core -p codex-app-server -p codex-mcp-server -p codex-rollout -p codex-rollout-tracecargo test -p codex-app-server skills_changed_notification_is_emitted_after_skill_change