[codex] Add response.processed websocket request#21284
Open
pakrym-oai wants to merge 2 commits intomainfrom
Open
[codex] Add response.processed websocket request#21284pakrym-oai wants to merge 2 commits intomainfrom
pakrym-oai wants to merge 2 commits intomainfrom
Conversation
pakrym-oai
force-pushed
the
pakrym/response-processed-ws
branch
from
74bd628 to
6b2d486
Compare
jif-oai
approved these changes
May 6, 2026
| && outcome.is_ok() | ||
| && let Some(response_id) = completed_response_id.as_deref() | ||
| { | ||
| client_session.send_response_processed(response_id).await; |
Collaborator
There was a problem hiding this comment.
This looks a little early.. we send response.processed before the in-flight work is drained and before the cancellation check below. This sounds race-prone to me
Collaborator
There was a problem hiding this comment.
Btw can we also keep this off the critical path if it's best effort only? Right now a stuck ws write can hold up a finished or cancelled turn until idle_timeout
| )); | ||
| }; | ||
|
|
||
| send_websocket_request( |
Collaborator
There was a problem hiding this comment.
Should we also clears failed ws here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.processedwebsocket request payload and sender for Responses API websockets.response.processedfromtry_run_sampling_requestafter a response completes, local turn processing succeeds, and the session-owned feature flag is enabled.Validation
just fmtcargo test -p codex-core response_processedcargo test -p codex-api responses_websocketcargo test -p codex-features responses_websocket_response_processed_is_under_developmentgit diff --checkjust fix -p codex-api -p codex-core -p codex-featuresgit diff --check origin/main...HEAD