[codex] Deduplicate invalid skill load warnings#21274
[codex] Deduplicate invalid skill load warnings#21274canvrno-oai wants to merge 1 commit intomainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d80e27f888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if self | ||
| .skill_load_warnings_by_cwd | ||
| .get(cwd) | ||
| .is_some_and(|previous_errors| previous_errors == &errors) |
There was a problem hiding this comment.
The dedupe compares the error Vec in order, but skill-load errors are produced from filesystem directory iteration, which is not guaranteed to be stable. With two invalid SKILL.md files, the same persistent batch can arrive in a different order and this check treats it as changed, re-emitting the duplicate warnings the commit intends to suppress. Sort or compare as a set by path/message before storing/comparing.
Useful? React with 👍 / 👎.
1 participant
Avoid repeatedly inserting identical invalid
SKILL.mdwarnings when skills are refreshed while the same parse errors persist.Tests:
cargo test -p codex-tui(2260 passed; 2 existing status permission-profile tests failed because/etc/codex/requirements.tomlrejectsDangerFullAccess).