Skip to content

Add workspace announcement polling client#21224

Open
xli-oai wants to merge 2 commits intoxli-codex/workspace-message-headline-pollingfrom
xli-codex/workspace-message-announcement-polling
Open

Add workspace announcement polling client#21224
xli-oai wants to merge 2 commits intoxli-codex/workspace-message-headline-pollingfrom
xli-codex/workspace-message-announcement-polling

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented May 5, 2026

Summary

  • Stack on Add workspace message backend client plumbing #21223 for shared backend-client models, read method, and feature flag.
  • Start an app-server background poller for announcement workspace messages only when workspace_messages is enabled.
  • Poll every 15 minutes with a 5s timeout, fail open on auth/network/timeouts, and fetch the actual announcement messages while preserving backend order.
  • Do not ack or render yet.

Validation

  • just fmt
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-backend-client
  • cargo check --manifest-path codex-rs/Cargo.toml -p codex-app-server
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-features

@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label May 5, 2026 — with ChatGPT Codex Connector
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e04aa0c12f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/backend-client/src/types.rs Outdated
@xli-oai xli-oai force-pushed the xli-codex/workspace-message-announcement-polling branch from 987efd4 to 36ac967 Compare May 5, 2026 19:27
@xli-oai xli-oai changed the base branch from main to xli-codex/workspace-message-headline-polling May 5, 2026 19:28
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented May 5, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xli-oai xli-oai force-pushed the xli-codex/workspace-message-announcement-polling branch from 92d9a19 to 67ea9ca Compare May 6, 2026 03:10
@xli-oai xli-oai force-pushed the xli-codex/workspace-message-headline-polling branch from 871e3ba to b3dca30 Compare May 6, 2026 04:39
@xli-oai xli-oai requested a review from a team as a code owner May 6, 2026 04:39
@xli-oai xli-oai force-pushed the xli-codex/workspace-message-headline-polling branch from b3dca30 to 1f1a7fa Compare May 6, 2026 06:17
@xli-oai xli-oai force-pushed the xli-codex/workspace-message-announcement-polling branch from 67ea9ca to 24a843d Compare May 6, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant