Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbd2243458
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5a7ad87d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(mcp_requirements) = self.config_layer_stack.requirements().mcp_servers.as_ref() | ||
| && mcp_requirements.value.is_empty() |
There was a problem hiding this comment.
After inserting built-ins above, requirements filtering only runs when the allowlist is empty. With a non-empty managed mcp_servers allowlist that omits memories, the built-in memories server remains enabled, bypassing the admin allowlist. Filter built-ins against all present MCP requirements, not just the empty case.
Useful? React with 👍 / 👎.
1 participant
No description provided.