Skip to content

fix(chat): hide tool context for ACP chats#3074

Closed
meijieru wants to merge 1 commit intoolimorris:mainfrom
meijieru:hide-acp-tool-context
Closed

fix(chat): hide tool context for ACP chats#3074
meijieru wants to merge 1 commit intoolimorris:mainfrom
meijieru:hide-acp-tool-context

Conversation

@meijieru
Copy link
Copy Markdown
Contributor

@meijieru meijieru commented Apr 28, 2026

Summary

  • hide tool and tool-group context entries by default when the chat adapter is ACP
  • keep HTTP chat tool context behavior unchanged
  • add regression coverage for ACP single tools and tool groups

Test

  • make test_file FILE=tests/interactions/chat/tools/test_tool_registry.lua

@meijieru meijieru force-pushed the hide-acp-tool-context branch from 9d4aa62 to e117663 Compare April 28, 2026 18:04
@meijieru meijieru force-pushed the hide-acp-tool-context branch from e117663 to abccebf Compare April 28, 2026 18:06
@olimorris
Copy link
Copy Markdown
Owner

FYI ACP adapters can't use tools so this should not be an issue.

@meijieru
Copy link
Copy Markdown
Contributor Author

That makes sense. However, I currently have default_tools = { "agent" } configured primarily for the HTTP adapter. To address this, we could either implement this display filter for tool context or scope the default_tools configuration specifically to the HTTP adapter.

@olimorris
Copy link
Copy Markdown
Owner

This PR is too light on details. You've ignored the default PR template, you've not shared any config which allows me to see what the issue your trying to fix is. And broadly speaking, 131 lines of new code with 3 lines of commentary in a PR is not going to work for me.

@olimorris olimorris closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants