fix(chat): hide tool context for ACP chats#3074
Closed
meijieru wants to merge 1 commit intoolimorris:mainfrom
Closed
fix(chat): hide tool context for ACP chats#3074meijieru wants to merge 1 commit intoolimorris:mainfrom
meijieru wants to merge 1 commit intoolimorris:mainfrom
Conversation
9d4aa62 to
e117663
Compare
e117663 to
abccebf
Compare
Owner
|
FYI ACP adapters can't use tools so this should not be an issue. |
Contributor
Author
|
That makes sense. However, I currently have default_tools = { "agent" } configured primarily for the HTTP adapter. To address this, we could either implement this display filter for tool context or scope the default_tools configuration specifically to the HTTP adapter. |
Owner
|
This PR is too light on details. You've ignored the default PR template, you've not shared any config which allows me to see what the issue your trying to fix is. And broadly speaking, 131 lines of new code with 3 lines of commentary in a PR is not going to work for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test