Skip to content

feat(acp): add Deep Agents as ACP adapter#3053

Closed
toniher wants to merge 7 commits intoolimorris:mainfrom
toniher:deepagents
Closed

feat(acp): add Deep Agents as ACP adapter#3053
toniher wants to merge 7 commits intoolimorris:mainfrom
toniher:deepagents

Conversation

@toniher
Copy link
Copy Markdown

@toniher toniher commented Apr 21, 2026

Description

Add a new adapter for Deep Agents. Basically, an adaptation of existing ones. Tested against Gemini models and worked OK.

Checklist

  • [X ] I've read the contributing guidelines and have adhered to them in this PR
  • [X ] I confirm that this PR has been majority created by me, and not AI (unless stated in the "AI Usage" section above)
  • [ X] I've run make all to ensure docs are generated, tests pass and StyLua has formatted the code
  • (optional) I've added test coverage for this fix/feature
  • (optional) I've updated the README and/or relevant docs pages

@toniher toniher changed the title Add Deep Agents as ACP adapter feat(acp): add Deep Agents as ACP adapter Apr 21, 2026
@toniher
Copy link
Copy Markdown
Author

toniher commented Apr 22, 2026

@olimorris when running make all and creating txt documentation, it has also created some additional bits of text. Staring from line ~3184


::: code-group


````MARKDOWN [MARKDOWN] ~
... many lines below ...

I don't know if this was intended or there is any bug there...

@olimorris
Copy link
Copy Markdown
Owner

Thanks for the PR but unfortunately you've not followed the PR template.

I've been mulling over adding this to CodeCompanion. I'm not a fan of the project becoming a repository for ACP adapters where I'm having to continually review and add them.

I propose sharing this in the discussion should anyone else in the community wish to use it.

@olimorris olimorris closed this Apr 29, 2026
@toniher
Copy link
Copy Markdown
Author

toniher commented Apr 30, 2026

I think it is a valid point since there will be an increasing number of agent CLIs and not necessarily all of them will become popular. I managed to include it via my configuration in the end. I think it might be worth to add it in the documentation somewhere here https://codecompanion.olimorris.dev/configuration/adapters-acp#configuring-acp-adapters I can start a discussion about adding this in the documentation.

@olimorris
Copy link
Copy Markdown
Owner

Because it's not part of the plugin and I won't support it, the docs would be misleading. I have a user contributed section of the discussions where this could be shared though. There's quite a few user contributed adapters there

@toniher
Copy link
Copy Markdown
Author

toniher commented May 1, 2026

Because it's not part of the plugin and I won't support it, the docs would be misleading. I have a user contributed section of the discussions where this could be shared though. There's quite a few user contributed adapters there

Because it's not part of the plugin and I won't support it, the docs would be misleading. I have a user contributed section of the discussions where this could be shared though. There's quite a few user contributed adapters there

I referred not to this actual ACP adapter, but to any custom one a potential user might want, so people would know how they could include them in their configs the easier, the better. And maybe also point to the discussions section so they are aware it exists (I wasn't, for instance).

@olimorris
Copy link
Copy Markdown
Owner

Oh apologies. Yes that's an awesome idea and I would love you to contribute that seeing as you figured this out in the first place without any docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants