fix(chat): nil tool name in on_tool_output

[cairijun]

Description

Fix the tool parameter in on_tool_output callback always being nil.

Root cause: In Chat:add_tool_output method, the callback args used tool_call.name, but tool_call is the raw LLM tool call object (i.e., tool.function_call) which doesn't have a top-level .name property.

Fix: Changed tool_call.name to tool.name, which is correctly set in both _handle_tool_error and _resolve_and_prepare_tool.

Files changed:

• lua/codecompanion/interactions/chat/init.lua — single-line fix
• tests/interactions/chat/tools/builtin/test_tool_output.lua — added test for callback parameters

AI Usage

Used CodeCompanion + GLM5 to help diagnose the issue and write the test case.

Related Issue(s)

N/A

Screenshots

N/A

Checklist

• I've read the contributing guidelines and have adhered to them in this PR
• I confirm that this PR has been majority created by me, and not AI (unless stated in the "AI Usage" section above)
• I've run make all to ensure docs are generated, tests pass and StyLua has formatted the code
• (optional) I've added test coverage for this fix/feature
• (optional) I've updated the README and/or relevant docs pages

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes the on_tool_output callback tool argument being nil by passing the resolved tool’s name instead of the raw LLM tool-call object’s (missing) name.

Changes:

• Update Chat:add_tool_output to pass tool.name into callback args.
• Add a regression test asserting correct callback args and that callback mutations affect stored message content.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lua/codecompanion/interactions/chat/init.lua	Fix callback args to use tool.name so args.tool is not nil.
tests/interactions/chat/tools/builtin/test_tool_output.lua	Add regression test ensuring on_tool_output receives correct args and can mutate output.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[olimorris]

Great spot and thanks for the fix. Let's move the test to test_chat as that's where the other callback tests are.

[cairijun]

Great spot and thanks for the fix. Let's move the test to test_chat as that's where the other callback tests are.

done