fix(acp): gracefully clean the queue on interrupt to stop#3009
Closed
cenk1cenk2 wants to merge 1 commit intoolimorris:mainfrom
Closed
fix(acp): gracefully clean the queue on interrupt to stop#3009cenk1cenk2 wants to merge 1 commit intoolimorris:mainfrom
cenk1cenk2 wants to merge 1 commit intoolimorris:mainfrom
Conversation
cenk1cenk2
force-pushed
the
patch-9
branch
5 times, most recently
from
0b620e5 to
80d8960
Compare
fix: update message fix: . fix: . fix: . fix: add guard for prompt fix: update fix: . fix: update fix: .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is a race condition on interrupting an ACP request, which I think was introduced with
v19+.So the flow is something like as follows.
AI Usage
Related Issue(s)
Screenshots
Checklist
make allto ensure docs are generated, tests pass and StyLua has formatted the code