Skip to content

fix(ui): disambiguate the two "compare" links #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 3 commits into from
Mar 21, 2026
Merged

fix(ui): disambiguate the two "compare" links #2180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b241b93
fix(ui): disambiguate the two "compare" links
serhalp Mar 21, 2026
e2a0b53
chore: remove ellipsis
ghostdevv Mar 21, 2026
f51ab6e
Merge branch 'main' into serhalp/pkg-compare-btn-text
ghostdevv Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/Package/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ const fundingUrl = computed(() => {
aria-keyshortcuts="c"
classicon="i-lucide:git-compare"
>
<span class="max-sm:sr-only">{{ $t('package.links.compare') }}</span>
<span class="max-sm:sr-only">{{ $t('package.links.compare_this_package') }}</span>
</LinkBase>
<!-- Package likes -->
<TooltipApp
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@
"code": "code",
"docs": "docs",
"fund": "fund",
"compare": "compare"
"compare": "compare",
"compare_this_package": "compare this package..."
},
"likes": {
"like": "Like this package",
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@
"code": "code",
"docs": "docs",
"fund": "donner",
"compare": "comparer"
"compare": "comparer",
"compare_this_package": "comparer ce paquet..."
},
"likes": {
"like": "Liker ce paquet",
Expand Down
3 changes: 3 additions & 0 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,9 @@
},
"compare": {
"type": "string"
},
"compare_this_package": {
"type": "string"
}
},
"additionalProperties": false
Expand Down
Loading