Skip to content

fix: remove pm-panel-id#1480

Merged
ghostdevv merged 3 commits intonpmx-dev:mainfrom
radosvet93:fix-remove-pm-panel-a11y
Feb 13, 2026
Merged

fix: remove pm-panel-id#1480
ghostdevv merged 3 commits intonpmx-dev:mainfrom
radosvet93:fix-remove-pm-panel-a11y

Conversation

@radosvet93
Copy link
Copy Markdown
Contributor

@radosvet93 radosvet93 commented Feb 13, 2026

Resolves #1424 and related to #1425 and #1449

I don't see the issues in the terminal anymore, and it doesn't have any errors from the browser, testing with the Wave A11y extension

image

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 9:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 9:40pm
npmx-lunaria Ignored Ignored Feb 13, 2026 9:40pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

The pull request removes ARIA tabpanel semantics and their bindings from two install sections on the package page. Divs previously using role="tabpanel" with :id and :aria-labelledby in the Binary-only install and Regular install areas are replaced with plain divs. The useSelectedPackageManager() call and the computed activePmId (defaulting to npm) are deleted. Placement and behaviour of the TerminalExecute component and surrounding logic are unchanged.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes remove the useSelectedPackageManager hook and associated tabpanel ARIA bindings, which directly resolves the broken ARIA references reported in issue #1424.
Out of Scope Changes check ✅ Passed All changes in the pull request are scoped to fixing broken ARIA references in the package page component, which aligns with the objectives of issue #1424.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
Description check ✅ Passed The pull request description clearly relates to the changeset by addressing broken ARIA references and accessibility issues identified in issue #1424, which aligns with the removal of tabpanel semantics and ARIA bindings from the code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit 7fe73b0 Feb 13, 2026
17 checks passed
WarningImHack3r pushed a commit to WarningImHack3r/npmx.dev that referenced this pull request Feb 14, 2026
alex-key pushed a commit to alex-key/npmx.dev that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

broken aria references

2 participants