fix: correct links to deps versions#1384
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe Dependencies.vue component has been updated to implement version normalisation. The change introduces semver.clean functionality to process dependency versions, creating both cleaned (cleanVersion) and original (origVersion) version entries. Iteration logic has been refactored from array-based tuples to object-destructured entries carrying name, origVersion, and cleanVersion. Sorting algorithms, rendering paths, and display logic have been updated to accommodate the new data structure, with navigation using cleaned versions whilst user-facing text preserves the original version strings. Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
hm. I think originally this was added deliberately so you just go to, e.g. https://npmx.dev/nuxt@^2 |
|
Oh, oops... Well, now I'm not sure where reality lies🫠 Got it, thanks What do you think would be better behavior for versions like ">= 18.0.0"? Should I repeat your logic or navigate to the latest version? |
If a range was specified in the dependencies, we had an invalid link. This caused 404 links, unnecessary prefetched, and just a bad experience.
I changed it so that we additionally clean up the versions, and if it results in valid version - the link will point to a specific version, otherwise - to the latest one. I was thinking about changing it to disabled, but it seems behavior with latest version is a bit more convenient (the perfect option is to find the exact latest version under range, but it's to much requests - I'll try to look into this option later)