feat: add ASDF as community install option #8847
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -188,6 +188,16 @@ | |||||||||||||||||||||||||||||||||||||||||||||
| "url": "https://github.com/tj/n", | ||||||||||||||||||||||||||||||||||||||||||||||
| "info": "layouts.download.codeBox.platformInfo.n" | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
| ,{ | ||||||||||||||||||||||||||||||||||||||||||||||
| "id": "ASDF", | ||||||||||||||||||||||||||||||||||||||||||||||
| "icon": "asdf", | ||||||||||||||||||||||||||||||||||||||||||||||
| "name": "ASDF", | ||||||||||||||||||||||||||||||||||||||||||||||
| "compatibility": { | ||||||||||||||||||||||||||||||||||||||||||||||
| "os": ["MAC", "LINUX", "WIN"] | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+192
to
+196
There was a problem hiding this comment. The new install method introduces a new There was a problem hiding this comment. ASDF incorrectly listed as Windows-compatibleMedium Severity The ASDF compatibility includes   Reviewed by Cursor Bugbot for commit 2c29d15. Configure here. |
||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||
| "url": "https://github.com/asdf-vm/asdf", | ||||||||||||||||||||||||||||||||||||||||||||||
| "info": "layouts.download.codeBox.platformInfo.asdf" | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+192
to
+199
There was a problem hiding this comment.
|
||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
190
to
+200
There was a problem hiding this comment. The array item separator is formatted as
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||
| ], | ||||||||||||||||||||||||||||||||||||||||||||||
| "packageManagers": [ | ||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ | |||||
| "footer": { | ||||||
| "legal": "Copyright © <foundationName>OpenJS Foundation</foundationName> et les contributeurs Node.js. Tous droits réservés.\nLa <foundationName>OpenJS Foundation</foundationName> détient des marques déposées et utilise des marques commerciales.\nPour consulter la liste des marques de la <foundationName>OpenJS Foundation</foundationName>, veuillez vous référer à notre <trademarkPolicy>Politique relative aux marques</trademarkPolicy> ainsi qu’à la <trademarkList>Liste des marques</trademarkList>.\nLes marques et logos qui ne figurent pas dans la <trademarkList>liste des marques de la OpenJS Foundation</trademarkList> sont des marques commerciales™ ou des marques déposées® appartenant à leurs détenteurs respectifs. Leur utilisation n’implique aucune affiliation ni approbation de leur part.", | ||||||
| "links": { | ||||||
| "foundationName": "OpenJS Foundation", | ||||||
|
There was a problem hiding this comment. Unrelated locale changes revert translated foundation nameLow Severity In Additional Locations (1)Reviewed by Cursor Bugbot for commit 2c29d15. Configure here. |
||||||
| "aiCodingAssistantsPolicy": "Politique relative aux assistants de codage basés sur l'IA", | ||||||
| "termsOfUse": "Conditions d’utilisation", | ||||||
| "privacyPolicy": "Politique de confidentialité", | ||||||
|
|
@@ -299,6 +299,7 @@ | |||||
| "choco": "Chocolatey est un gestionnaire de paquets pour Windows.", | ||||||
| "docker": "Docker est une plateforme de conteneurisation.", | ||||||
| "n": "\"n\" est un gestionnaire de versions Node.js multiplateforme.", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. Non-English locales have untranslated ASDF descriptionsMedium Severity The Additional Locations (2)Reviewed by Cursor Bugbot for commit c21dac7. Configure here. There was a problem hiding this comment. This new French locale string is still in English. Please translate it to French to match the other localized strings in
Suggested change
|
||||||
| "volta": "\"Volta\" est un gestionnaire de versions Node.js multiplateforme." | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -393,6 +393,7 @@ | |||||
| "choco": "Chocolatey adalah manajer paket untuk Windows.", | ||||||
| "docker": "Docker adalah platform kontainerisasi.", | ||||||
| "n": "\"n\" adalah manajer versi Node.js lintas-platform.", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new Indonesian locale string is still in English. Please translate it to Indonesian to keep
Suggested change
|
||||||
| "volta": "\"Volta\" adalah manajer versi Node.js lintas-platform." | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -299,6 +299,7 @@ | |||||
| "choco": "ChocolateyはWIndows用のパッケージマネージャーです。", | ||||||
| "docker": "Dockerはコンテナー化に関するプラットフォームです。", | ||||||
| "n": "\"n\"はクロスプラットフォームに対応したNode.jsのバージョンマネージャーです。", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new Japanese locale string is still in English. Please provide a Japanese translation for consistency with the rest of
Suggested change
|
||||||
| "volta": "\"Volta\"はクロスプラットフォームに対応したNode.jsのバージョンマネージャーです。" | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -279,7 +279,8 @@ | |||||
| "fnm": "\"fnm\"은 플랫폼 간 Node.js 버전 관리자입니다.", | ||||||
| "brew": "Homebrew는 macOS와 Linux용 패키지 관리자입니다.", | ||||||
| "choco": "Chocolatey는 Windows용 패키지 관리자입니다.", | ||||||
| "docker": "Docker는 컨테이너화 플랫폼입니다. ", | ||||||
|
There was a problem hiding this comment. While touching this line to add the trailing comma, consider removing the trailing space inside the string value (it will render as an extra space in the UI).
Suggested change
|
||||||
| "asdf": "ASDF is a cross-platform version manager." | ||||||
|
There was a problem hiding this comment. This new Korean locale string is still in English. Please translate it to Korean so
Suggested change
|
||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -399,6 +399,7 @@ | |||||
| "choco": "Chocolatey é um gerenciador de pacotes para Windows.", | ||||||
| "docker": "Docker é uma plataforma de conteinerização.", | ||||||
| "n": "\"n\" é um gerenciador de versões do Node.js multiplataforma.", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new pt-BR locale string is still in English. Please translate it to Brazilian Portuguese to keep
Suggested change
|
||||||
| "volta": "\"Volta\" é um gerenciador de versões do Node.js multiplataforma." | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -286,7 +286,8 @@ | |||||
| "brew": "Homebrew é um gestor de pacote para macOS e Linux.", | ||||||
| "choco": "Chocolatey é um gestor de pacote para Windows.", | ||||||
| "docker": "Docker é uma plataforma de contentorização.", | ||||||
| "volta": "\"Volta\" é um gestor de versão de Node.js multiplataforma.", | ||||||
| "asdf": "ASDF is a cross-platform version manager." | ||||||
|
There was a problem hiding this comment. This new Portuguese locale string is still in English. Please provide a pt-PT translation for consistency with the rest of
Suggested change
|
||||||
| } | ||||||
| } | ||||||
| }, | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -380,6 +380,7 @@ | |||||
| "choco": "Chocolatey este un manager de pachete pentru Windows.", | ||||||
| "docker": "Docker este o platformă de containerizare.", | ||||||
| "n": "„n” este un manager de versiuni Node.js multiplatformă.", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new Romanian locale string is still in English. Please translate it to Romanian to match the other localized entries in
Suggested change
|
||||||
| "volta": "„Volta” este un manager de versiuni Node.js multiplatformă." | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |||||
| "footer": { | ||||||
| "legal": "பதிப்புரிமை <foundationName>OpenJS நிறுவனம்</foundationName> மற்றும் Node.js பங்களிப்பாளர்கள். அனைத்து உரிமைகளும் பாதுகாக்கப்பட்டவை. <foundationName>OpenJS நிறுவனம்</foundationName> பதிவுசெய்யப்பட்ட வர்த்தக முத்திரைகளைக் கொண்டுள்ளது மற்றும் வர்த்தக முத்திரைகளைப் பயன்படுத்துகிறது. <foundationName>OpenJS நிறுவனம்</foundationName>-ன் வர்த்தக முத்திரைகளின் பட்டியலுக்கு, தயவுசெய்து எங்களது <trademarkPolicy>வர்த்தக முத்திரை கொள்கை</trademarkPolicy> மற்றும் <trademarkList>வர்த்தக முத்திரை பட்டியல் </trademarkList>-ஐப் பார்க்கவும்.<trademarkList>OpenJS Foundation வர்த்தக முத்திரைகளின் பட்டியலில்</trademarkList> குறிப்பிடப்படாத வர்த்தக முத்திரைகள் மற்றும் லோகோக்கள், அந்தந்த உரிமையாளர்களின் வர்த்தக முத்திரைகள்™ அல்லது பதிவுசெய்யப்பட்ட® வர்த்தக முத்திரைகள் ஆகும். அவற்றைப் பயன்படுத்துவது அவர்களுடனான எந்தவொரு தொடர்பையோ அல்லது அவர்களது அங்கீகாரத்தையோ குறிக்காது.", | ||||||
| "links": { | ||||||
| "foundationName": "OpenJS Foundation", | ||||||
| "termsOfUse": "பயன்பாட்டு விதிமுறைகள்", | ||||||
| "privacyPolicy": "தனியுரிமை கொள்கை", | ||||||
| "bylaws": "துணை விதிகள்", | ||||||
|
|
@@ -399,6 +399,7 @@ | |||||
| "choco": "Chocolatey என்பது Windows இற்கான பேக்கேஜ் மேலாளர்.", | ||||||
| "docker": "Docker என்பது containerization தளம்.", | ||||||
| "n": "\"n\" குறுக்கு-பிளாட்ஃபார்ம் Node பதிப்பு மேலாளர்.", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new Tamil locale string is still in English. Please translate it to Tamil so the
Suggested change
|
||||||
| "volta": "\"Volta\" விரைந்து வேலை செய்யும் Node மேலாளர்." | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -298,6 +298,7 @@ | |||||
| "choco": "Chocolatey — це менеджер пакетів для Windows.", | ||||||
| "docker": "Docker — це платформа контейнеризації.", | ||||||
| "n": "«n» — це кросплатформний менеджер версій Node.js.", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new Ukrainian locale string is still in English. Please provide a Ukrainian translation for consistency with the rest of
Suggested change
|
||||||
| "volta": "«Volta» — це кросплатформний менеджер версій Node.js." | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -288,6 +288,7 @@ | |||||
| "choco": "Chocolatey 是一款 Windows 软件包管理器。", | ||||||
| "docker": "Docker 是一个容器化平台。", | ||||||
| "n": "\"n\" 是一个跨平台的 Node.js 版本管理器。", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new zh-cn locale string is still in English. Please translate it to Simplified Chinese to keep
Suggested change
|
||||||
| "volta": "\"Volta\" 是一个跨平台的 Node.js 版本管理器。" | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -313,6 +313,7 @@ | |||||
| "choco": "Chocolatey 是 Windows 的套件管理程式。", | ||||||
| "docker": "Docker 是一款容器化平台。", | ||||||
| "n": "「n」是跨平台的 Node.js 版本管理程式。", | ||||||
| "asdf": "ASDF is a cross-platform version manager.", | ||||||
|
There was a problem hiding this comment. This new zh-tw locale string is still in English. Please translate it to Traditional Chinese to match the rest of
Suggested change
|
||||||
| "volta": "「Volta」是跨平台的 Node.js 版本管理程式。" | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing icon component causes runtime crash
High Severity
The
"icon": "asdf"value references a non-existent export from@node-core/ui-components/Icons/InstallationMethod. That module only exportsChoco,Docker,FNM,Homebrew,N,NVM, andVolta— there is noasdf(orASDF) export. ThecreateIconfunction will resolveIconModule["asdf"]toundefined, and React will crash when attempting to render<undefined />.Reviewed by Cursor Bugbot for commit c21dac7. Configure here.