Skip to content

chore: remove unmaintained mastodon link from footer (#7873) #8843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7487 wants to merge 2 commits into from
+7 −9
Closed

chore: remove unmaintained mastodon link from footer (#7873) #8843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e67e28
chore: remove unmaintained mastodon link from footer (#7873)
7487 Apr 25, 2026
9d673ae
fix: add overflow-auto to sidebar navigation (#8521)
7487 Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions apps/site/navigation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,6 @@
"link": "https://discord.gg/nodejs",
"alt": "Discord"
},
{
"icon": "mastodon",
"link": "https://social.lfx.dev/@nodejs",
"alt": "Mastodon"
},
{
"icon": "bluesky",
"link": "https://bsky.app/profile/nodejs.org",
Expand Down Expand Up @@ -170,4 +165,4 @@
}
}
}
}
}
9 changes: 6 additions & 3 deletions packages/ui-components/src/Containers/Sidebar/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
dark:border-neutral-900
dark:bg-neutral-950;

.navigation {
@apply ml:flex
.navigation {
@apply ml:flex
flex-1
overflow-y-auto
scroll-smooth
hidden;
}
}
Copy link
Copy Markdown

@cursor cursor Bot Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated sidebar CSS change accidentally included

Medium Severity

The PR's changes to packages/ui-components/src/Containers/Sidebar/index.module.css add flex-1, overflow-y-auto, and scroll-smooth to .navigation. This makes each SidebarGroup an independently sized and scrollable region, nested within the main sidebar scroll, materially altering layout and scrolling behavior. These changes appear unrelated to the PR's stated purpose and also introduce an indentation inconsistency.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9d673ae. Configure here.


.mobileSelect {
@apply ml:hidden
Expand Down
Loading