Skip to content

feat(navigation): don't render navItems when no children #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 8 commits into from
Mar 15, 2026
Merged

feat(navigation): don't render navItems when no children #8722

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01abe90
chore: update next-env.d.ts
igorrm19 Mar 7, 2026
a12bf9f
Merge branch 'nodejs:main' into main
igorrm19 Mar 10, 2026
0ef360c
feat: minimize mobile nav empty space (#8719)
igorrm19 Mar 14, 2026
ed7a98c
Update import path for routes type definitions
igorrm19 Mar 14, 2026
e07127b
Update packages/ui-components/src/Containers/NavBar/index.tsx
igorrm19 Mar 14, 2026
bede84a
Fix conditional rendering of navItems in NavBar
igorrm19 Mar 14, 2026
a55e468
Remove blank line in NavBar component
igorrm19 Mar 14, 2026
1fdbd0d
style: fix prettier formatting in NavBar
igorrm19 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-components/src/Containers/NavBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const NavBar: FC<PropsWithChildren<NavbarProps>> = ({
/>

<div className={classNames(styles.main, `hidden peer-checked:flex`)}>
{navItems && (
{!!navItems?.length && (
Comment thread
igorrm19 marked this conversation as resolved.
Outdated
<div className={styles.navItems}>
{navItems.map(({ text, link, target }) => (
<NavItem
Expand Down