Skip to content

chore(ci): run GHA on ready_for_review #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 4 commits into from
Oct 28, 2025
Merged

chore(ci): run GHA on ready_for_review #8286

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b372c1
chore(ci): do not run GHA on draft PR
aduh95 Oct 28, 2025
a67d1e1
Update lint and tests workflow for draft PRs
aduh95 Oct 28, 2025
c0ffe75
Update .github/workflows/build.yml
aduh95 Oct 28, 2025
e8577a1
Apply suggestions from code review
aduh95 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
pull_request:
branches:
- main
types: [opened, synchronize, reopened, ready_for_review]
merge_group:

defaults:
Expand All @@ -31,6 +32,7 @@ env:
jobs:
build:
name: Build on ${{ matrix.os }}
if: github.event.pull_request.draft == false
Comment thread
aduh95 marked this conversation as resolved.
Outdated
runs-on: ${{ matrix.os }}

strategy:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/lint-and-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:
pull_request:
branches:
- main
types: [opened, synchronize, reopened, ready_for_review]
merge_group:

# The permissions specified below apply to workflows triggered by `merge_group`, `push`, and `pull_request` events that originate from the same repository (non-fork).
Expand All @@ -39,6 +40,7 @@ env:
jobs:
lint:
name: Quality checks
if: github.event.pull_request.draft == false
Comment thread
aduh95 marked this conversation as resolved.
Outdated
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -96,6 +98,7 @@ jobs:

tests:
name: Tests
if: github.event.pull_request.draft == false
Comment thread
aduh95 marked this conversation as resolved.
Outdated
runs-on: ubuntu-latest

steps:
Expand Down
Loading