Skip to content

fix: tr cannot be a child of table#7968

Closed
btea wants to merge 1 commit intonodejs:mainfrom
btea:fix/table-tr-nested-error
Closed

fix: tr cannot be a child of table#7968
btea wants to merge 1 commit intonodejs:mainfrom
btea:fix/table-tr-nested-error

Conversation

@btea
Copy link
Copy Markdown

@btea btea commented Jul 9, 2025

Description

image

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings July 9, 2025 00:18
@btea btea requested a review from a team as a code owner July 9, 2025 00:18
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 9, 2025 0:19am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 9, 2025

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures valid HTML structure by wrapping standalone <tr> elements within <tbody> tags in the Chinese branding page.

  • Added opening and closing <tbody> around each table’s <tr> block.
Comments suppressed due to low confidence (2)

apps/site/pages/zh-cn/about/branding.mdx:70

  • The Tailwind class height-[80px] is invalid; use h-[80px] to correctly set the image height.
    <img alt="绿色 JS 图标" src="/static/logos/jsIconGreen.svg" className="height-[80px] mx-auto w-[71px]" width="71" height="80" />

apps/site/pages/zh-cn/about/branding.mdx:24

  • [nitpick] For readability, indent the <tbody> and its nested <tr> elements under the <table> tag consistently.
<table>

Copy link
Copy Markdown
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead change this in Crowdin?

@btea
Copy link
Copy Markdown
Author

btea commented Jul 9, 2025

It seems that it is correct on Crowdin, but it is not synchronized in the repository.

image

@avivkeller
Copy link
Copy Markdown
Member

In that case, it will sync at the next Crowdin download.

@avivkeller avivkeller closed this Jul 9, 2025
@btea btea deleted the fix/table-tr-nested-error branch July 9, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants