fix: tr cannot be a child of table#7968
Closed
btea wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures valid HTML structure by wrapping standalone <tr> elements within <tbody> tags in the Chinese branding page.
- Added opening and closing
<tbody>around each table’s<tr>block.
Comments suppressed due to low confidence (2)
apps/site/pages/zh-cn/about/branding.mdx:70
- The Tailwind class
height-[80px]is invalid; useh-[80px]to correctly set the image height.
<img alt="绿色 JS 图标" src="/static/logos/jsIconGreen.svg" className="height-[80px] mx-auto w-[71px]" width="71" height="80" />
apps/site/pages/zh-cn/about/branding.mdx:24
- [nitpick] For readability, indent the
<tbody>and its nested<tr>elements under the<table>tag consistently.
<table>
avivkeller
requested changes
Jul 9, 2025
Member
avivkeller
left a comment
There was a problem hiding this comment.
Can you instead change this in Crowdin?
Author
Member
|
In that case, it will sync at the next Crowdin download. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.