Skip to content

lib: handle --permission-audit when propagating flags#63047

Open
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS:fix-permission-audit-child-process-env
Open

lib: handle --permission-audit when propagating flags#63047
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS:fix-permission-audit-child-process-env

Conversation

@RafaelGSS
Copy link
Copy Markdown
Member

As titled.

I have also included --permission-audit in the check of FFI permissions.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Apr 30, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.65%. Comparing base (a7f487f) to head (b1ec186).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/process/permission.js 44.44% 5 Missing ⚠️
lib/child_process.js 0.00% 2 Missing ⚠️
lib/ffi.js 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63047      +/-   ##
==========================================
+ Coverage   89.63%   89.65%   +0.01%     
==========================================
  Files         708      708              
  Lines      220402   220423      +21     
  Branches    42271    42270       -1     
==========================================
+ Hits       197551   197610      +59     
+ Misses      14706    14662      -44     
- Partials     8145     8151       +6     
Files with missing lines Coverage Δ
lib/child_process.js 95.45% <0.00%> (-0.10%) ⬇️
lib/ffi.js 95.56% <60.00%> (-1.16%) ⬇️
lib/internal/process/permission.js 92.75% <44.44%> (-7.25%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants