Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/internal/blob.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,12 @@ function getSource(source, endings) {
}

const sourcesConverter = createSequenceConverter((source, opts = kEmptyObject) => {
if (isBlob(source) || isAnyArrayBuffer(source) || isArrayBufferView(source)) {
if (isBlob(source)) {
return source;
}
if (isAnyArrayBuffer(source) || isArrayBufferView(source)) {
return converters.BufferSource(source, opts);
}
return converters.DOMString(source, opts);
});

Expand All @@ -149,7 +152,10 @@ class Blob {
constructor(sources = [], options) {
markTransferMode(this, true, false);

const sources_ = sourcesConverter(sources);
const sources_ = sourcesConverter(sources, {
__proto__: null,
context: 'sources',
});

validateDictionary(options, 'options');
let {
Expand Down
24 changes: 24 additions & 0 deletions test/parallel/test-webapi-sharedarraybuffer-rejection.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const common = require('../common');
const assert = require('assert');
const test = require('node:test');
const { Blob } = require('buffer');
const { ReadableStream } = require('stream/web');

const sab = new SharedArrayBuffer(8);
Expand Down Expand Up @@ -98,6 +99,29 @@ test('ReadableByteStreamController.enqueue() rejects SAB-backed DataView', async
reader.releaseLock();
});

// -- Blob --

test('Blob rejects SharedArrayBuffer part', () => {
assert.throws(
() => new Blob([sab]),
{ code: 'ERR_INVALID_ARG_TYPE' },
);
});

test('Blob rejects SAB-backed Uint8Array part', () => {
assert.throws(
() => new Blob([sabView]),
{ code: 'ERR_INVALID_ARG_TYPE' },
);
});

test('Blob rejects SAB-backed DataView part', () => {
assert.throws(
() => new Blob([sabDataView]),
{ code: 'ERR_INVALID_ARG_TYPE' },
);
});

// -- SharedWebIDL converters --

const { converters } = require('internal/webidl');
Expand Down
Loading