deps: fix libffi macos build#63006
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 28, 2026
Merged
Conversation
Signed-off-by: Paolo Insogna <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
ShogunPanda
added
ffi
Contributor
|
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
Member
|
Should we make a release test build? |
Contributor
Author
|
@targos Totally open to it. How? |
Member
|
I can do it. |
Contributor
Author
|
Ok. Let me know how it works and if it succeeds. Thanks! |
Member
Contributor
Author
|
@targos I don't have access to that CI. Let me know how it goes. Thanks a lot buddy! |
Collaborator
bengl
approved these changes
Apr 28, 2026
Collaborator
Contributor
Author
|
@targos Did the test release succeeded? |
Member
|
release-pkg build failed :( |
Member
|
Link: https://ci-release.nodejs.org/job/iojs+release/11719/nodes=macos15-release-pkg/console End of logs with error: |
Member
|
But it's about Temporal, so I guess unrelated to this fix |
ShogunPanda
added
the
author ready
Contributor
Author
|
Ok, can I merge this then? |
Member
|
@richardlau Is there proof in the logs that the libffi issue is fixed? |
Member
I think from the logs and no sign of the errors (#62787) are encouraging. Plus I think the libffi issue was masking the Temporal issue under Rosetta 2 as the build was previously failing before it attempted linking to the Temporal library😞. As an aside, since we've had these two issues in succession that occur under Rosetta 2 it would help if we had something to catch these earlier than the release CI (GitHub actions?). |
richardlau
approved these changes
Apr 28, 2026
Contributor
Author
|
@richardlau @targos Do you want me to fast-track and merge or what for few days? |
richardlau
added
the
commit-queue
Member
Let's try fast-tracking. We can't be in a worse state and might help us look at the Temporal issue that was masked by the one attempted to be fixed here. |
panva
approved these changes
Apr 28, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 186995e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62787.