http2: add writableObjectMode and writableNeedDrain getters to Http2ServerResponse#63004
Closed
AmSach wants to merge 2 commits intonodejs:mainfrom
Closed
http2: add writableObjectMode and writableNeedDrain getters to Http2ServerResponse#63004AmSach wants to merge 2 commits intonodejs:mainfrom
AmSach wants to merge 2 commits intonodejs:mainfrom
Conversation
…erverResponse Fixes nodejs#63000. Http2ServerResponse was missing these two properties that exist on OutgoingMessage and are documented as returning boolean values. Added getters mirroring the pattern already used for writableFinished, writableCorked, writableHighWaterMark, etc. in compat.js.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63004 +/- ##
==========================================
- Coverage 89.66% 89.65% -0.01%
==========================================
Files 707 707
Lines 219501 219517 +16
Branches 42087 42087
==========================================
+ Hits 196807 196811 +4
- Misses 14588 14590 +2
- Partials 8106 8116 +10
🚀 New features to boost your workflow:
|
These properties were added to Http2ServerResponse but had no assertions in the existing test. Adding type checks to ensure they return booleans and are accessible on the response object. Refs: nodejs#63000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63000.
Http2ServerResponse was missing these two properties that exist on OutgoingMessage and are documented as returning boolean values.
Added getters mirroring the pattern already used for writableFinished, writableCorked, writableHighWaterMark, etc. in compat.js.