lib: make AbortSignal.timeout() parameter handling spec-compliant#62997
Closed
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Closed
lib: make AbortSignal.timeout() parameter handling spec-compliant#62997Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Renegade334 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62997 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.01%
==========================================
Files 707 707
Lines 219506 219509 +3
Branches 42087 42085 -2
==========================================
+ Hits 196782 196817 +35
+ Misses 14625 14587 -38
- Partials 8099 8105 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently validate the argument to
AbortSignal.timeout()as a uint32, whereas the specification dictates that this be converted to an integer and then validated as a uint64. Not sure how many users are clamouring for an AbortSignal that aborts during the next ice age, but the coercion behaviour is something we should definitely be implementing.Refs: https://dom.spec.whatwg.org/#ref-for-dom-abortsignal-timeout
Fixes: #58592