Skip to content

tools: do not include docs in slim tarball#62989

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:faster-tarball-packing
Open

tools: do not include docs in slim tarball#62989
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:faster-tarball-packing

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 27, 2026

Pulling and running doc-kit takes quite a long time (removing it cuts the make tar time to completion in half), when we don't really need it in test-shared.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 27, 2026
@aduh95 aduh95 force-pushed the faster-tarball-packing branch from 0eae337 to 4eff2bf Compare April 27, 2026 14:36
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 27, 2026
@aduh95 aduh95 force-pushed the faster-tarball-packing branch 2 times, most recently from 8e89e0a to 1f35166 Compare April 27, 2026 15:07
@aduh95 aduh95 force-pushed the faster-tarball-packing branch from 1f35166 to 457563c Compare April 27, 2026 15:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (0a9b67e) to head (457563c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62989      +/-   ##
==========================================
+ Coverage   89.64%   89.65%   +0.01%     
==========================================
  Files         707      707              
  Lines      219506   219509       +3     
  Branches    42087    42082       -5     
==========================================
+ Hits       196782   196810      +28     
+ Misses      14625    14588      -37     
- Partials     8099     8111      +12     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants