Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions test/parallel/test-sqlite-database-sync-dispose.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,59 @@ suite('DatabaseSync.prototype[Symbol.dispose]()', () => {
db.close();
}, /database is not open/);
});

test('invalidates prepared statements', () => {
const db = new DatabaseSync(nextDb());
db.exec(`
CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER);
INSERT INTO data (key, val) VALUES (1, 2);
`);

const select = db.prepare('SELECT * FROM data');
const insert = db.prepare('INSERT INTO data (key, val) VALUES (?, ?)');
const iterator = select.iterate();

db[Symbol.dispose]();
assert.strictEqual(db.isOpen, false);

for (const method of ['prepare', 'exec']) {
assert.throws(() => {
db[method]('SELECT 1');
}, {
code: 'ERR_INVALID_STATE',
message: /database is not open/,
});
}

assert.throws(() => {
select.get();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
assert.throws(() => {
select.all();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
assert.throws(() => {
select.iterate();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
assert.throws(() => {
insert.run(2, 4);
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
assert.throws(() => {
iterator.next();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
});
});
114 changes: 114 additions & 0 deletions test/parallel/test-sqlite-database-sync.js
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,120 @@ suite('DatabaseSync.prototype.close()', () => {
});
t.assert.strictEqual(db.isOpen, false);
});

test('invalidates prepared statements', (t) => {
const db = new DatabaseSync(nextDb());
db.exec(`
CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER);
INSERT INTO data (key, val) VALUES (1, 2);
`);

const select = db.prepare('SELECT * FROM data');
const insert = db.prepare('INSERT INTO data (key, val) VALUES (?, ?)');
const iterator = select.iterate();

t.assert.strictEqual(db.close(), undefined);
t.assert.strictEqual(db.isOpen, false);

for (const method of ['prepare', 'exec']) {
t.assert.throws(() => {
db[method]('SELECT 1');
}, {
code: 'ERR_INVALID_STATE',
message: /database is not open/,
});
}

t.assert.throws(() => {
select.get();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
select.all();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
select.iterate();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
insert.run(2, 4);
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
iterator.next();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
});

test('keeps prepared statements invalid after reopening', (t) => {
const db = new DatabaseSync(nextDb());
t.after(() => {
if (db.isOpen) db.close();
});

db.exec(`
CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER);
INSERT INTO data (key, val) VALUES (1, 2);
`);

const select = db.prepare('SELECT * FROM data');
const insert = db.prepare('INSERT INTO data (key, val) VALUES (?, ?)');
const iterator = select.iterate();

db.close();
db.open();

t.assert.throws(() => {
select.get();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
select.all();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
select.iterate();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
insert.run(2, 4);
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});
t.assert.throws(() => {
iterator.next();
}, {
code: 'ERR_INVALID_STATE',
message: /statement has been finalized/,
});

t.assert.deepStrictEqual(
db.prepare('SELECT * FROM data').all(),
[{ __proto__: null, key: 1, val: 2 }],
);
t.assert.strictEqual(
db.exec('INSERT INTO data (key, val) VALUES (2, 4)'),
undefined,
);
});
});

suite('DatabaseSync.prototype.prepare()', () => {
Expand Down
Loading