Skip to content

webstreams: narrow ReadableStreamBYOBRequest.view to Uint8Array#62970

Closed
vedparkasharya wants to merge 1 commit intonodejs:mainfrom
vedparkasharya:fix-webstreams-view-type-62952
Closed

webstreams: narrow ReadableStreamBYOBRequest.view to Uint8Array#62970
vedparkasharya wants to merge 1 commit intonodejs:mainfrom
vedparkasharya:fix-webstreams-view-type-62952

Conversation

@vedparkasharya
Copy link
Copy Markdown

ReadableStreamBYOBRequest.view is always constructed as a Uint8Array,
and the specification will be updated to enforce this.

Refs: whatwg/streams#1367
Fixes: #62952

ReadableStreamBYOBRequest.view is always constructed as a Uint8Array,
and the specification will be updated to enforce this. Reflect this
by changing the documented return type from ArrayBufferView to
Uint8Array.

Refs: whatwg/streams#1367
Fixes: nodejs#62952
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Apr 26, 2026
@gurgunday
Copy link
Copy Markdown
Member

gurgunday commented Apr 26, 2026

Thanks, but duplicate of #62958

@gurgunday gurgunday added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Apr 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (c202696) to head (84e6dec).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62970      +/-   ##
==========================================
- Coverage   89.66%   89.66%   -0.01%     
==========================================
  Files         706      706              
  Lines      219416   219416              
  Branches    42073    42080       +7     
==========================================
- Hits       196738   196732       -6     
- Misses      14576    14600      +24     
+ Partials     8102     8084      -18     
Files with missing lines Coverage Δ
lib/internal/webstreams/readablestream.js 98.54% <100.00%> (ø)

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vedparkasharya
Copy link
Copy Markdown
Author

Thanks @gurgunday for pointing that out! I see that #62958 already covers this exact change. I'll close this PR to avoid duplication. Appreciate the heads-up! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Issues and PRs that are duplicates of other issues or PRs. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webstreams: narrow ReadableStreamBYOBRequest.view to Uint8Array

3 participants