perf_hooks: do not record timerify entry for async throw#62947
Open
maruthang wants to merge 1 commit intonodejs:mainfrom
Open
perf_hooks: do not record timerify entry for async throw#62947maruthang wants to merge 1 commit intonodejs:mainfrom
maruthang wants to merge 1 commit intonodejs:mainfrom
Conversation
`timerify` used `result.finally(processComplete)` for thenables, which recorded a histogram sample and enqueued a `function` PerformanceEntry on async rejection. The sync-throw path never reached `processComplete` because the throw happens inside ReflectApply, so async- and sync-throwing variants of the same function produced different observable outputs. Use `result.then(onFulfilledTimerified)` with no onRejected so rejections propagate unchanged and `processComplete` runs only on fulfillment. Relax the thenable check from `finally` to `then`, since a thenable is only required to implement `then`. Fixes: nodejs#42743 Signed-off-by: Maruthan G <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timerifyusedresult.finally(processComplete)for thenables,which recorded a histogram sample and enqueued a
functionPerformanceEntry on async rejection. The sync-throw path never
reached
processCompletebecause the throw happens insideReflectApply, so async- and sync-throwing variants of the same
function produced different observable outputs.
Use
result.then(onFulfilledTimerified)with no onRejected sorejections propagate unchanged and
processCompleteruns only onfulfillment. Relax the thenable check from
finallytothen,since a thenable is only required to implement
then.Fixes: #42743