assert: surface prototype mismatch in deepStrictEqual diff#62944
Open
maruthang wants to merge 1 commit intonodejs:mainfrom
Open
assert: surface prototype mismatch in deepStrictEqual diff#62944maruthang wants to merge 1 commit intonodejs:mainfrom
maruthang wants to merge 1 commit intonodejs:mainfrom
Conversation
When two values share the same enumerable shape but have different
prototypes, the diff produced by `assert.deepStrictEqual` rendered
the misleading `Values have same structure but are not
reference-equal: {}` message, leaving the user without a hint that
the prototype is the differentiator.
Add an explicit `Object prototypes differ: <actualProto> !==
<expectedProto>` line above the inspected body when the operator is
`deepStrictEqual` or `partialDeepStrictEqual` and the top-level
prototypes differ. Other operators (e.g., `strictEqual([], [])`)
keep their existing `notIdentical` fallback message.
Fixes: nodejs#50397
Signed-off-by: Maruthan G <[email protected]>
nodejs-github-bot
added
assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two values share the same enumerable shape but have different
prototypes, the diff produced by
assert.deepStrictEqualrenderedthe misleading
Values have same structure but are not reference-equal: {}message, leaving the user without a hint thatthe prototype is the differentiator.
Add an explicit
Object prototypes differ: <actualProto> !== <expectedProto>line above the inspected body when the operator isdeepStrictEqualorpartialDeepStrictEqualand the top-levelprototypes differ. Other operators (e.g.,
strictEqual([], []))keep their existing
notIdenticalfallback message.Fixes: #50397
Note: I was unable to run the test suite locally (no built
out/Release/nodeon this Windows host). Both files passnode --check; the fix logic was verified in a standalone harness that exercises the patched branch. Looking forward to CI verification.