Skip to content

Fix windows DNS server resolution #62938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greguintow wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

Fix windows DNS server resolution #62938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions deps/cares/src/lib/ares_sysconfig_win.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,11 +638,9 @@ ares_status_t ares_init_sysconfig_windows(const ares_channel_t *channel,
if (get_SuffixList_Windows(&line)) {
sysconfig->domains = ares_strsplit(line, ", ", &sysconfig->ndomains);
ares_free(line);
/* Keep discovered DNS servers even if suffix parsing fails. */
if (sysconfig->domains == NULL) {
status = ARES_EFILE;
}
if (status != ARES_SUCCESS) {
goto done;
sysconfig->ndomains = 0;
}
}

Expand Down
Loading