tools: add non-default OpenSSL versions to the test-shared workflow#62862
Open
panva wants to merge 3 commits intonodejs:mainfrom
Open
tools: add non-default OpenSSL versions to the test-shared workflow#62862panva wants to merge 3 commits intonodejs:mainfrom
panva wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
panva
added
commit-queue-squash
Contributor
|
Adding extra GHA workflows comes at the expense of spending more minutes to prepare security releases. We can skip the test-shared workflow on the private repo, but idk if it's worth it given that there are some path that we only run on that workflow. |
aduh95
reviewed
Apr 21, 2026
aduh95
reviewed
Apr 21, 2026
Member
Author
The OpenSSL versions are a big gap. Since we don't/can't keep up with the versions in CI. |
aduh95
reviewed
Apr 21, 2026
aduh95
reviewed
Apr 21, 2026
panva
force-pushed
the
additional-openssl-in-shared
branch
from
8bab015 to
1311e12
Compare
aduh95
reviewed
Apr 22, 2026
aduh95
reviewed
Apr 22, 2026
anonrig
approved these changes
Apr 24, 2026
Contributor
|
I did another pass at this PR, and tested aduh95@a01a6ef. Could you have a look, and feel free to pull it and/or adapt from it |
Signed-off-by: Filip Skokan <[email protected]>
panva
force-pushed
the
additional-openssl-in-shared
branch
from
bc5e7eb to
85900e8
Compare
Member
Author
|
@aduh95 looks great, i pulled it in and lint-fixed it |
aduh95
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional OpenSSL shared-libraries matrix to
test-shared.ymlso PRs run against additional supported OpenSSL releases. No more waiting for a full CI to find out a crypto/TLS change is broken on another version 🙏.build-opensslnow uses a committed matrix intest-shared.yml, regenerated by the existing weeklynixpkgs-unstableupdater so the pin bump and tested OpenSSL variants stay in sync in a single PR.1.1.1.SUPPORTED_OPENSSL_VERSIONremains a manually maintained value intools/nix/collect-openssl-matrix.sh, and drives per-entrycontinue-on-errorin the autogenerated matrix so releases newer than what we explicitly support do not fail GHA.