Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions doc/api/debugger.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ script to debug.
```console
$ node inspect myscript.js
< Debugger listening on ws://127.0.0.1:9229/621111f9-ffcb-4e82-b718-48a145fa5db8
< For help, see: https://nodejs.org/en/docs/inspector
< For help, see: https://nodejs.org/api/inspector.html
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page is actually moved to https://nodejs.org/learn/getting-started/debugging.

Suggested change
< For help, see: https://nodejs.org/api/inspector.html
< For help, see: https://nodejs.org/learn/getting-started/debugging

<
connecting to 127.0.0.1:9229 ... ok
< Debugger attached.
Expand Down Expand Up @@ -45,7 +45,7 @@ setTimeout(() => {
console.log('hello');
$ NODE_INSPECT_RESUME_ON_START=1 node inspect myscript.js
< Debugger listening on ws://127.0.0.1:9229/f1ed133e-7876-495b-83ae-c32c6fc319c2
< For help, see: https://nodejs.org/en/docs/inspector
< For help, see: https://nodejs.org/api/inspector.html
<
connecting to 127.0.0.1:9229 ... ok
< Debugger attached.
Expand Down Expand Up @@ -131,7 +131,7 @@ is not loaded yet:
```console
$ node inspect main.js
< Debugger listening on ws://127.0.0.1:9229/48a5b28a-550c-471b-b5e1-d13dd7165df9
< For help, see: https://nodejs.org/en/docs/inspector
< For help, see: https://nodejs.org/api/inspector.html
<
connecting to 127.0.0.1:9229 ... ok
< Debugger attached.
Expand All @@ -158,7 +158,7 @@ given expression evaluates to `true`:
```console
$ node inspect main.js
< Debugger listening on ws://127.0.0.1:9229/ce24daa8-3816-44d4-b8ab-8273c8a66d35
< For help, see: https://nodejs.org/en/docs/inspector
< For help, see: https://nodejs.org/api/inspector.html
<
connecting to 127.0.0.1:9229 ... ok
< Debugger attached.
Expand Down Expand Up @@ -253,7 +253,7 @@ or break on the first line for step-by-step debugging.
```console
$ node --inspect index.js
Debugger listening on ws://127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29
For help, see: https://nodejs.org/en/docs/inspector
For help, see: https://nodejs.org/api/inspector.html
```

(In the example above, the UUID dc9010dd-f8b8-4ac5-a510-c1a114ec7d29
Expand Down
4 changes: 2 additions & 2 deletions doc/api/inspector.md
Original file line number Diff line number Diff line change
Expand Up @@ -465,12 +465,12 @@ Return the URL of the active inspector, or `undefined` if there is none.
```console
$ node --inspect -p 'inspector.url()'
Debugger listening on ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34
For help, see: https://nodejs.org/en/docs/inspector
For help, see: https://nodejs.org/api/inspector.html
ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34

$ node --inspect=localhost:3000 -p 'inspector.url()'
Debugger listening on ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a
For help, see: https://nodejs.org/en/docs/inspector
For help, see: https://nodejs.org/api/inspector.html
ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a

$ node -p 'inspector.url()'
Expand Down
3 changes: 1 addition & 2 deletions src/inspector_socket_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ void PrintDebuggerReadyMessage(
FormatWsAddress(host, server_socket->port(), id, true).c_str());
}
}
fprintf(out, "For help, see: %s\n",
"https://nodejs.org/en/docs/inspector");
fprintf(out, "For help, see: %s\n", "https://nodejs.org/api/inspector.html");
fflush(out);
}

Expand Down
2 changes: 1 addition & 1 deletion test/internet/test-inspector-help-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function check(url, cb) {
});

res.on('end', common.mustCall(() => {
assert.match(result, />Debugging Node\.js</);
assert.match(result, /<title>Inspector \| Node\.js/);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page https://nodejs.org/learn/getting-started/debugging still match this matcher.

cb();
}));
})).on('error', common.mustNotCall);
Expand Down
Loading