-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
meta: require DCO signoff in commit message guidelines #62510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+10
−0
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -199,6 +199,14 @@ A good commit message should describe what changed and why. | |
| contain an explanation about the reason of the breaking change, which | ||
| situation would trigger the breaking change, and what is the exact change. | ||
|
|
||
| 6. Your commit must contain the `Signed-off-by` line with your name and email | ||
| address as an acknowledgement that you agree to the [Developer Certificate of Origin][]. | ||
| Bot generated commits are exempt from this requirement. If a commit has | ||
| multiple authors, the `Signed-off-by` line should be added for each author; | ||
| and at least one should match the author information in the commit metadata. | ||
|
jasnell marked this conversation as resolved.
|
||
| This rule does not apply to dependency updates (e.g. cherry-picks), release | ||
| commits, or backport commits. | ||
|
|
||
| Sample complete commit message: | ||
|
|
||
| ```text | ||
|
|
@@ -210,6 +218,7 @@ less. | |
|
|
||
| Fixes: https://github.com/nodejs/node/issues/1337 | ||
| Refs: https://eslint.org/docs/rules/space-in-parens.html | ||
| Signed-off-by: J. Random User <[email protected]> | ||
| ``` | ||
|
|
||
| If you are new to contributing to Node.js, please try to do your best at | ||
|
|
@@ -594,6 +603,7 @@ More than one subsystem may be valid for any particular issue or pull request. | |
| [Building guide]: ../../BUILDING.md | ||
| [CI (Continuous Integration) test run]: #continuous-integration-testing | ||
| [Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md | ||
| [Developer Certificate of Origin]: ../../CONTRIBUTING.md#developers-certificate-of-origin-11 | ||
| [Onboarding guide]: ../../onboarding.md | ||
| [approved]: #getting-approvals-for-your-pull-request | ||
| [benchmark results]: writing-and-running-benchmarks.md | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.