Skip to content

sqlite: bind ArrayBuffer#62061

Open
mike-git374 wants to merge 1 commit intonodejs:mainfrom
mike-git374:bind-array-buffer
Open

sqlite: bind ArrayBuffer#62061
mike-git374 wants to merge 1 commit intonodejs:mainfrom
mike-git374:bind-array-buffer

Conversation

@mike-git374
Copy link
Copy Markdown

Fixes: #61396

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 1, 2026
Copy link
Copy Markdown
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.

Comment thread src/node_sqlite.cc Outdated
Comment thread src/node_sqlite.cc Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (c9acf34) to head (5f75022).
⚠️ Report is 276 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62061      +/-   ##
==========================================
- Coverage   89.74%   89.69%   -0.06%     
==========================================
  Files         674      676       +2     
  Lines      204883   206503    +1620     
  Branches    39379    39543     +164     
==========================================
+ Hits       183882   185213    +1331     
- Misses      13279    13443     +164     
- Partials     7722     7847     +125     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.78% <66.66%> (-0.12%) ⬇️

... and 206 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/node_sqlite.cc
Comment thread test/parallel/test-sqlite-data-types.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer

3 participants