Skip to content

crypto: fix missing nullptr check on RSA_new() #61888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndossche wants to merge 3 commits into from
+9 −1
Closed

crypto: fix missing nullptr check on RSA_new() #61888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00b4cf8
crypto: fix missing nullptr check on RSA_new()
ndossche Feb 19, 2026
34f2531
fixup! throw
ndossche Feb 23, 2026
09ed002
fix: throw exception when EVPKeyPointer::NewRSA() fails
ndossche Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/crypto/crypto_rsa.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,8 @@ KeyObjectData ImportJWKRsaKey(Environment* env,
KeyType type = d_value->IsString() ? kKeyTypePrivate : kKeyTypePublic;

RSAPointer rsa(RSA_new());
if (!rsa) return {};
Comment thread
addaleax marked this conversation as resolved.
Outdated

ncrypto::Rsa rsa_view(rsa.get());

ByteSource n = ByteSource::FromEncodedString(env, n_value.As<String>());
Expand Down
Loading