-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
src: fix --build-sea default executable path
#61708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−1
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bff93ce
src: fix `--build-sea` default executable path
alexsch01 8b62eac
Add test
alexsch01 ebb070f
Cleanup after test
alexsch01 a756a12
use temp dir
alexsch01 d2f5377
fix lint
alexsch01 3e0ab1d
Apply suggestions from code review
alexsch01 94a3be0
Update test-build-sea-custom-argv0.js
alexsch01 bf058ae
Update test-build-sea-custom-argv0.js
alexsch01 6b6a27c
Apply suggestions from code review
alexsch01 643a70e
Update test-build-sea-custom-argv0.js
alexsch01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| 'use strict'; | ||
| // This tests --build-sea with a custom argv0 value. | ||
|
|
||
| require('../common'); | ||
|
|
||
| const { skipIfBuildSEAIsNotSupported } = require('../common/sea'); | ||
|
|
||
| skipIfBuildSEAIsNotSupported(); | ||
|
|
||
| const tmpdir = require('../common/tmpdir'); | ||
| const fixtures = require('../common/fixtures'); | ||
| const { copyFileSync } = require('fs'); | ||
|
|
||
| const { spawnSyncAndAssert } = require('../common/child_process'); | ||
| tmpdir.refresh(); | ||
|
|
||
| copyFileSync( | ||
|
Check failure on line 17 in test/sea/test-build-sea-custom-argv0.js
|
||
| fixtures.path('sea-config.json'), | ||
|
alexsch01 marked this conversation as resolved.
Outdated
|
||
| tmpdir.resolve('sea-config.json'), | ||
| ); | ||
|
|
||
| copyFileSync( | ||
| fixtures.path('sea.js'), | ||
|
alexsch01 marked this conversation as resolved.
Outdated
|
||
| tmpdir.resolve('sea.js'), | ||
| ); | ||
|
|
||
| spawnSyncAndAssert( | ||
| process.execPath, | ||
| ['--build-sea', tmpdir.resolve('sea-config.json')], { | ||
| cwd: tmpdir.path, | ||
| argv0: 'argv0', | ||
| }, { | ||
| stdout: /Generated single executable/, | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.