Skip to content

http2: fix FileHandle leak in respondWithFile #61707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Feb 8, 2026
+55 −0
Merged

http2: fix FileHandle leak in respondWithFile #61707

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4dd6b
http2: fix FileHandle leak in respondWithFile
Han5991 Feb 6, 2026
f6d474a
test: add regression test for http2 fd leak
Han5991 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2680,6 +2680,8 @@ function processRespondWithFD(self, fd, headers, offset = 0, length = -1,
try {
headersList = buildNgHeaderString(headers, assertValidPseudoHeaderResponse);
} catch (err) {
if (self.ownsFd)
tryClose(fd);
self.destroy(err);
return;
}
Expand All @@ -2693,6 +2695,8 @@ function processRespondWithFD(self, fd, headers, offset = 0, length = -1,
const ret = self[kHandle].respond(headersList, streamOptions);

if (ret < 0) {
if (self.ownsFd)
tryClose(fd);
self.destroy(new NghttpError(ret));
return;
}
Expand Down
Loading