fs: remove known issues test test-fs-cp-filter#59682
Closed
npaun wants to merge 1 commit intonodejs:mainfrom
Closed
fs: remove known issues test test-fs-cp-filter#59682npaun wants to merge 1 commit intonodejs:mainfrom
npaun wants to merge 1 commit intonodejs:mainfrom
Conversation
anonrig
approved these changes
Aug 29, 2025
Member
|
Ping @nodejs/fs |
jasnell
requested changes
Aug 29, 2025
Member
jasnell
left a comment
There was a problem hiding this comment.
$ ./node test/known_issues/test-fs-cp-filter.js
node:internal/errors:546
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Buffer
at join (node:path:1339:7)
at copyDir (node:internal/fs/cp/cp-sync:164:23)
at onDir (node:internal/fs/cp/cp-sync:136:25)
at getStats (node:internal/fs/cp/cp-sync:68:12)
at cpSyncFn (node:internal/fs/cp/cp-sync:58:10)
at cpSync (node:fs:3123:3)
at Object.<anonymous> (/home/jsnell/projects/node/node/test/known_issues/test-fs-cp-filter.js:28:1)
at Module._compile (node:internal/modules/cjs/loader:1737:14)
at Object..js (node:internal/modules/cjs/loader:1870:10)
at Module.load (node:internal/modules/cjs/loader:1469:32) {
code: 'ERR_INVALID_ARG_TYPE'
}
I think this is still relevant.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59682 +/- ##
==========================================
- Coverage 89.83% 89.34% -0.49%
==========================================
Files 666 667 +1
Lines 195337 196850 +1513
Branches 38353 38343 -10
==========================================
+ Hits 175474 175884 +410
- Misses 12323 13336 +1013
- Partials 7540 7630 +90 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test isn't correct. In fact, both
cpandcpSynchave the same behaviour.filteris invoked twice, despite the comment saying it's invoked only once incpSync.