src: remove temporary string in the parsing of --snapshot-config#59580
Open
lemire wants to merge 1 commit intonodejs:mainfrom
Open
src: remove temporary string in the parsing of --snapshot-config#59580lemire wants to merge 1 commit intonodejs:mainfrom
lemire wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Aug 22, 2025
joyeecheung
approved these changes
Aug 22, 2025
MoLow
approved these changes
Aug 24, 2025
anonrig
reviewed
Aug 24, 2025
Comment on lines
+938
to
+939
| if (field.value().get_string().get(result.builder_script_path) || | ||
| result.builder_script_path.empty()) { |
Member
There was a problem hiding this comment.
Suggested change
| if (field.value().get_string().get(result.builder_script_path) || | |
| result.builder_script_path.empty()) { | |
| if (field.value().get_string().get(*result.builder_script_path) || | |
| result.builder_script_path->empty()) { |
Contributor
|
This pull request has been marked as stale due to 210 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small change following #59473 by @joyeecheung motivated by a remark from @anonrig : it seems that we create a temporary string needlessly.
This PR is not about performance per se, but rather code simplicity. It removes two lines of code.