tls: make Server.getTicketKeys throw instead of assert#58365
Open
nektro wants to merge 1 commit intonodejs:mainfrom
Open
tls: make Server.getTicketKeys throw instead of assert#58365nektro wants to merge 1 commit intonodejs:mainfrom
nektro wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58365 +/- ##
==========================================
- Coverage 89.89% 89.87% -0.02%
==========================================
Files 656 656
Lines 193141 193142 +1
Branches 37886 37888 +2
==========================================
- Hits 173623 173586 -37
- Misses 12051 12096 +45
+ Partials 7467 7460 -7
🚀 New features to boost your workflow:
|
Member
|
The linter pipeline section seems to be broken. |
Contributor
Author
|
anything i need to do on my end? |
nektro
force-pushed
the
nektro-patch-40171
branch
4 times, most recently
from
1e09a9f to
19a54a8
Compare
assert is for invariants and print a message about the condition being a bug in Node.js if false. throw ERR_INVALID_ARG_VALUE for publicly facing validation.
nektro
force-pushed
the
nektro-patch-40171
branch
from
19a54a8 to
b2dd7ec
Compare
joyeecheung
reviewed
Aug 19, 2025
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
The PR is updatingServer.setTicketKeys but the commit message talks about Server.getTicketKeys instead. Can you update the commit message?
| assert(keys.byteLength === 48, | ||
| 'Session ticket keys must be a 48-byte buffer'); | ||
| if (keys.byteLength !== 48) { | ||
| throw new ERR_INVALID_ARG_VALUE('keys', keys.byteLength, 'must be exactly 48 bytes'); |
Member
There was a problem hiding this comment.
Suggested change
| throw new ERR_INVALID_ARG_VALUE('keys', keys.byteLength, 'must be exactly 48 bytes'); | |
| throw new ERR_INVALID_ARG_VALUE('keys.byteLength', keys.byteLength, 'must be 48 bytes'); |
The original message looks a bit ambiguous to me by saying "received N" (but N=buffer.byteLength isn't the argument. The buffer is).
|
|
||
|
|
||
| Server.prototype.setTicketKeys = function setTicketKeys(keys) { | ||
| validateBuffer(keys); |
Member
There was a problem hiding this comment.
Suggested change
| validateBuffer(keys); | |
| validateBuffer(keys, 'keys'); |
This predated the PR but since it's adding a test for the message, let's align the two names.
| { | ||
| name: 'TypeError', | ||
| code: 'ERR_INVALID_ARG_TYPE', | ||
| message: 'The "buffer" argument must be an instance of Buffer, TypedArray, or DataView.' + |
Member
There was a problem hiding this comment.
Suggested change
| message: 'The "buffer" argument must be an instance of Buffer, TypedArray, or DataView.' + | |
| message: 'The "keys" argument must be an instance of Buffer, TypedArray, or DataView.' + |
| { | ||
| name: 'TypeError', | ||
| code: 'ERR_INVALID_ARG_VALUE', | ||
| message: `The argument 'keys' must be exactly 48 bytes. Received ${arg.byteLength}`, |
Member
There was a problem hiding this comment.
Suggested change
| message: `The argument 'keys' must be exactly 48 bytes. Received ${arg.byteLength}`, | |
| message: `The property 'keys.byteLength' must be exactly 48 bytes. Received ${arg.byteLength}`, |
Contributor
|
This pull request has been marked as stale due to 210 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert is for invariants and prints a message about the condition being a bug in Node.js if false.
throw ERR_INVALID_ARG_VALUE for publicly facing validation.
this brings it into sync with the validation done in configSecureContext.