src: ERR_ILLEGAL_CONSTRUCTOR thrown from c++ had the wrong constructor

[nektro]

this brings it into sync with the definition of this error in lib/internal/errors.js.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.19%. Comparing base (a436f7b) to head (ad03a4a).
⚠️ Report is 2288 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58364      +/-   ##
==========================================
- Coverage   90.24%   90.19%   -0.05%     
==========================================
  Files         633      635       +2     
  Lines      186859   187171     +312     
  Branches    36685    36750      +65     
==========================================
+ Hits       168622   168811     +189     
- Misses      11036    11124      +88     
- Partials     7201     7236      +35     

Files with missing lines	Coverage Δ
src/node_errors.h	87.50% <ø> (ø)

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jasnell]

I'm fine with this but keep in mind that changing the error type is semver-major

[aduh95]

The commit message should start with a verb in infinitive form, e.g. src: make `ERR_ILLEGAL_CONSTRUCTOR` inherit `TypeError` .

[nektro]

bump

[aduh95]

Can you use assert.match so in case of failure we get a more informative error message?

Suggested change

	assert(cp.stderr.includes(`TypeError: Illegal constructor\n`));
	assert(cp.stderr.includes(`code: 'ERR_ILLEGAL_CONSTRUCTOR'\n`));
	assert.match(cp.stderr, /TypeError: Illegal constructor\n(.*\n)*\s*code: 'ERR_ILLEGAL_CONSTRUCTOR'\n/);

[aduh95]

We don't need to test the message

Suggested change

message: 'Illegal constructor',

[avivkeller]

@nektro Please rebase :-)