tools: make use of modern syntax in tools/install.py#58167
tools: make use of modern syntax in tools/install.py#58167avivkeller wants to merge 3 commits intonodejs:mainfrom avivkeller:patch-510837
tools/install.py#58167Conversation
richardlau
left a comment
There was a problem hiding this comment.
This removes AIX and z/OS code.
Shouldn't it be the other way around? If there's a reason not to do this, you should be the one letting us know given you're the one suggesting the change. It's a very large change hard to review, and it's unclear what we get out of it. |
|
I've simplified. To clarify, my goal was to make this use pathlib, f-strings, a similar. |
|
Can someone run a. CI so this can land? |
|
/cc @nodejs/python |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
From my perspective, this file relies on a few outdated practices:
pathlibIf there is a reason for these outdated practices, feel free to let me know :-)